Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1094843005: Revert of Allow NEON on iOS. (Closed)

Created:
5 years, 8 months ago by mtklein
Modified:
5 years, 8 months ago
Reviewers:
caryclark, mtklein_C
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Allow NEON on iOS. (patchset #3 id:40001 of https://codereview.chromium.org/1091823002/) Reason for revert: need to coordinate this with chrome gyps/gn Original issue's description: > Allow NEON on iOS. > > I have nanobench building and running (Color32_arm_neon) on my iPad. > > No public API changes. > TBR=reed@google.com > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/e5043b7ea5170a639367b67c986568907576be4b TBR=caryclark@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/f3f9440372099bb44b29438ee0c445b7e1bd836d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M gyp/opts.gyp View 1 chunk +3 lines, -1 line 0 comments Download
M include/core/SkPreConfig.h View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of Allow NEON on iOS.
5 years, 8 months ago (2015-04-17 21:02:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1094843005/1
5 years, 8 months ago (2015-04-17 21:02:18 UTC) #2
commit-bot: I haz the power
5 years, 8 months ago (2015-04-17 21:02:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f3f9440372099bb44b29438ee0c445b7e1bd836d

Powered by Google App Engine
This is Rietveld 408576698