Rename some things around incremental marking triggers

src/heap/heap.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_HEAP_HEAP_H_
 #define V8_HEAP_HEAP_H_
 
 #include <cmath>
 
 #include "src/allocation.h"
@@ skipping 1223 matching lines @@
   inline void IncrementNodesCopiedInNewSpace() { nodes_copied_in_new_space_++; }
 
   inline void IncrementNodesPromoted() { nodes_promoted_++; }
 
   inline void IncrementYoungSurvivorsCounter(int survived) {
     DCHECK(survived >= 0);
     survived_last_scavenge_ = survived;
     survived_since_last_expansion_ += survived;
   }
 
-  inline bool NextGCIsLikelyToBeFull(intptr_t limit) {
-    if (FLAG_gc_global) return true;

[Erik Corry Chromium.org, 2015/04/17 10:40:41]

This is the only functional change. Previously, in --gc-global mode we would
always start incremental marking immediately after the previous GC.

This isn't really how I understand --gc-global which is described as "always
perform global GCs", ie it should just avoid new-space-only GCs.

I left in the bit about early incremental start with --stress-compaction,
because it seems like a stressy thing to do.

[Hannes Payer (out of office), 2015/04/17 10:48:17]

Acknowledged.

[titzer, 2015/04/20 12:47:24]

Your CL description claimed this was a refactoring CL. The subsequent functional
change and crashing on the waterfall on amd64 determined that was a lie.

-
+  inline bool HeapIsFullEnoughToStartIncrementalMarking(intptr_t limit) {

[Hannes Payer (out of office), 2015/04/17 10:48:17]

I don't feel strong about the function name.

     if (FLAG_stress_compaction && (gc_count_ & 1) != 0) return true;
 
     intptr_t adjusted_allocation_limit = limit - new_space_.Capacity();
 
     if (PromotedTotalSize() >= adjusted_allocation_limit) return true;
 
     return false;
   }
 
   void UpdateNewSpaceReferencesInExternalStringTable(
@@ skipping 819 matching lines @@
   void ConfigureInitialOldGenerationSize();
 
   void SelectScavengingVisitorsTable();
 
   void IdleMarkCompact(const char* message);
 
   bool TryFinalizeIdleIncrementalMarking(
       double idle_time_in_ms, size_t size_of_objects,
       size_t mark_compact_speed_in_bytes_per_ms);
 
-  bool WorthActivatingIncrementalMarking();
-
   void ClearObjectStats(bool clear_last_time_stats = false);
 
   inline void UpdateAllocationsHash(HeapObject* object);
   inline void UpdateAllocationsHash(uint32_t value);
   inline void PrintAlloctionsHash();
 
   // Object counts and used memory by InstanceType
   size_t object_counts_[OBJECT_STATS_COUNT];
   size_t object_counts_last_time_[OBJECT_STATS_COUNT];
   size_t object_sizes_[OBJECT_STATS_COUNT];
@@ skipping 528 matching lines @@
   DisallowHeapAllocation no_allocation;  // i.e. no gc allowed.
 
  private:
   DISALLOW_IMPLICIT_CONSTRUCTORS(PathTracer);
 };
 #endif  // DEBUG
 }
 }  // namespace v8::internal
 
 #endif  // V8_HEAP_HEAP_H_