chrome/chrome_exe.gypi - Issue 109483003: Make sure Chrome_elf.dll imports are correct and that it the first import of chrome.exe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_exe.gypi

Issue 109483003: Make sure Chrome_elf.dll imports are correct and that it the first import of chrome.exe (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Comments Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/chrome_exe.gypi

diff --git a/chrome/chrome_exe.gypi b/chrome/chrome_exe.gypi

index 7efcadb953129dfee84b7aac11df08be9ad03f46..84439e7ee05ffae116c70f407a92de3ea57dac05 100644

--- a/chrome/chrome_exe.gypi

+++ b/chrome/chrome_exe.gypi

@@ -463,6 +463,8 @@

}],

['OS=="win"', {

'dependencies': [

+ # Note that chrome_elf must be listed first. Do not reorder it.

+ '../chrome_elf/chrome_elf.gyp:chrome_elf',

'chrome_dll',

'chrome_nacl_win64',

'chrome_process_finder',

@@ -472,7 +474,6 @@

'../base/base.gyp:base',

'../breakpad/breakpad.gyp:breakpad_handler',

'../breakpad/breakpad.gyp:breakpad_sender',

- '../chrome_elf/chrome_elf.gyp:chrome_elf',

'../components/components.gyp:breakpad_component',

'../sandbox/sandbox.gyp:sandbox',

'app/policy/cloud_policy_codegen.gyp:policy',

« no previous file with comments | « no previous file | chrome_elf/chrome_elf.gyp » ('j') | chrome_elf/elf_imports_unittest.cc » ('J')