Make sure Chrome_elf.dll imports are correct and that it the first import of chrome.exe

chrome/chrome_exe.gypi

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'targets': [
+  {
+      'target_name': 'chrome',

[robertshield, 2014/01/09 20:55:56]

This should be windows-only right?

[Cait (Slow), 2014/01/10 22:00:54]

Done.

+      'type': 'none',
+      'dependencies': [ 'chrome_initial', ],
+       'actions': [
+       {
+          'variables': {
+            'reorder_py_path': '<(DEPTH)/build/win/reorder-imports.py',
+            'exe_input_path':'$(OutDir)\\initial',
+            'exe_output_path':'<(PRODUCT_DIR)',
+          },
+          'action_name': 'reodrer_imports',

[robertshield, 2014/01/09 20:55:56]

nit: reorder_imports

[Cait (Slow), 2014/01/10 22:00:54]

Done.

+          'inputs': [
+            '<(reorder_py_path)',
+            '<(exe_input_path)',
+            '<(exe_output_path)',

[robertshield, 2014/01/09 20:55:56]

just curious: why does this last one need to be an input?

[Cait (Slow), 2014/01/10 22:00:54]

it doesn't...in fact, it breaks things (passing the exe_input_path as an input
breaks things too apparently). 

I'm still trying to wrap my head around inputs and outputs of gyp actions. As
best I can tell, inputs are things that should exist before the action is run,
outputs should exist afterwards, and neither is in any way related to the args
you actually give to the py script.

+          ],
+          'outputs': [
+            '<(PRODUCT_DIR)\\chrome.exe',
+            '<(PRODUCT_DIR)\\chrome.exe.pdb',
+          ],
+          'action': [
+            'python',
+            '<(reorder_py_path)',
+            '-i', '<(exe_input_path)',
+            '-o', '<(exe_output_path)',
+          ],
+          'message': 'Reordering Imports',
+        },
+      ],
+    },
     {
-      'target_name': 'chrome',
+      'target_name': 'chrome_initial',
+      'product_name': 'chrome',

[robertshield, 2014/01/09 20:55:56]

just curious again: what does 'product_name' do?

[Cait (Slow), 2014/01/10 22:00:54]

product_name makes it chrome.exe rather than chrome_initial.exe

[robertshield, 2014/01/11 02:16:07]

Ok, makes sense. Perhaps a comment to this effect?

       'type': 'executable',
       'mac_bundle': 1,
       'variables': {
         'use_system_xdg_utils%': 0,
         'enable_wexit_time_destructors': 1,
       },
       'sources': [
         'app/chrome_exe_main_aura.cc',
         'app/chrome_exe_main_gtk.cc',
         'app/chrome_exe_main_mac.cc',
@@ skipping 442 matching lines @@
                 '../components/nacl.gyp:nacl_helper',
                 ],
             }],
           ],
           'dependencies': [
             '../sandbox/sandbox.gyp:sandbox',
           ],
         }],
         ['OS=="win"', {
           'dependencies': [
-            # Note that chrome_elf must be listed first. Do not reorder it.
-            '../chrome_elf/chrome_elf.gyp:chrome_elf',
             'chrome_dll',
             'chrome_nacl_win64',
             'chrome_process_finder',
             'chrome_version_resources',
             'installer_util',
             'image_pre_reader',
             '../base/base.gyp:base',
             '../breakpad/breakpad.gyp:breakpad_handler',
             '../breakpad/breakpad.gyp:breakpad_sender',
             '../components/components.gyp:breakpad_component',
             '../components/components.gyp:policy',
+            '../chrome_elf/chrome_elf.gyp:chrome_elf',
             '../sandbox/sandbox.gyp:sandbox',
           ],
           'sources': [
             'app/chrome_breakpad_client.cc',
             'app/chrome_breakpad_client.h',
             'app/chrome_exe.rc',
             'common/crash_keys.cc',
             'common/crash_keys.h',
             '<(SHARED_INTERMEDIATE_DIR)/chrome_version/chrome_exe_version.rc',
           ],
           'msvs_settings': {
             'VCLinkerTool': {
               'ImportLibrary': '$(OutDir)\\lib\\chrome_exe.lib',
+              'OutputFile': '$(OutDir)\\initial\\chrome.exe',
               'DelayLoadDLLs': [
                 'dbghelp.dll',
                 'dwmapi.dll',
                 'uxtheme.dll',
                 'ole32.dll',
                 'oleaut32.dll',
               ],
               'AdditionalDependencies': [ 'wintrust.lib' ],
               # Set /SUBSYSTEM:WINDOWS for chrome.exe itself.
               'SubSystem': '2',
@@ skipping 148 matching lines @@
               'dependencies': [
                 'chrome_nacl_win64',
               ],
             }],
           ],
         },
       ],
     }],
   ],
 }