Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: chrome/browser/history/history_types.h

Issue 10948045: introduce chrome/browser/common directory and move url_database(and its dependencies) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/history_notifications.h ('k') | chrome/browser/history/history_types.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history_types.h
===================================================================
--- chrome/browser/history/history_types.h (revision 157579)
+++ chrome/browser/history/history_types.h (working copy)
@@ -16,8 +16,9 @@
#include "base/stack_container.h"
#include "base/string16.h"
#include "base/time.h"
+#include "chrome/browser/common/url_database/template_url_id.h"
+#include "chrome/browser/common/url_database/url_database_types.h"
#include "chrome/browser/history/snippet.h"
-#include "chrome/browser/search_engines/template_url_id.h"
#include "chrome/common/ref_counted_util.h"
#include "chrome/common/thumbnail_score.h"
#include "content/public/common/page_transition_types.h"
@@ -41,157 +42,9 @@
typedef std::vector<GURL> RedirectList;
typedef int64 DownloadID; // Identifier for a download.
-typedef int64 FaviconID; // For favicons.
typedef int64 FaviconBitmapID; // Identifier for a bitmap in a favicon.
typedef int64 SegmentID; // URL segments for the most visited view.
-typedef int64 IconMappingID; // For page url and icon mapping.
-// URLRow ---------------------------------------------------------------------
-
-typedef int64 URLID;
-
-// Holds all information globally associated with one URL (one row in the
-// URL table).
-//
-// This keeps track of dirty bits, which are currently unused:
-//
-// TODO(brettw) the dirty bits are broken in a number of respects. First, the
-// database will want to update them on a const object, so they need to be
-// mutable.
-//
-// Second, there is a problem copying. If you make a copy of this structure
-// (as we allow since we put this into vectors in various places) then the
-// dirty bits will not be in sync for these copies.
-class URLRow {
- public:
- URLRow();
-
- explicit URLRow(const GURL& url);
-
- // We need to be able to set the id of a URLRow that's being passed through
- // an IPC message. This constructor should probably not be used otherwise.
- URLRow(const GURL& url, URLID id);
-
- virtual ~URLRow();
- URLRow& operator=(const URLRow& other);
-
- URLID id() const { return id_; }
-
- // Sets the id of the row. The id should only be manually set when a row has
- // been retrieved from the history database or other dataset based on criteria
- // other than its id (i.e. by URL) and when the id has not yet been set in the
- // row.
- void set_id(URLID id) { id_ = id; }
-
- const GURL& url() const { return url_; }
-
- const string16& title() const {
- return title_;
- }
- void set_title(const string16& title) {
- // The title is frequently set to the same thing, so we don't bother
- // updating unless the string has changed.
- if (title != title_) {
- title_ = title;
- }
- }
-
- // The number of times this URL has been visited. This will often match the
- // number of entries in the visit table for this URL, but won't always. It's
- // really designed for autocomplete ranking, so some "useless" transitions
- // from the visit table aren't counted in this tally.
- int visit_count() const {
- return visit_count_;
- }
- void set_visit_count(int visit_count) {
- visit_count_ = visit_count;
- }
-
- // Number of times the URL was typed in the Omnibox. This "should" match
- // the number of TYPED transitions in the visit table. It's used primarily
- // for faster autocomplete ranking. If you need to know the actual number of
- // TYPED transitions, you should query the visit table since there could be
- // something out of sync.
- int typed_count() const {
- return typed_count_;
- }
- void set_typed_count(int typed_count) {
- typed_count_ = typed_count;
- }
-
- base::Time last_visit() const {
- return last_visit_;
- }
- void set_last_visit(base::Time last_visit) {
- last_visit_ = last_visit;
- }
-
- // If this is set, we won't autocomplete this URL.
- bool hidden() const {
- return hidden_;
- }
- void set_hidden(bool hidden) {
- hidden_ = hidden;
- }
-
- // Helper functor that determines if an URLRow refers to a given URL.
- class URLRowHasURL {
- public:
- explicit URLRowHasURL(const GURL& url) : url_(url) {}
-
- bool operator()(const URLRow& row) {
- return row.url() == url_;
- }
-
- private:
- const GURL& url_;
- };
-
- protected:
- // Swaps the contents of this URLRow with another, which allows it to be
- // destructively copied without memory allocations.
- void Swap(URLRow* other);
-
- private:
- // This class writes directly into this structure and clears our dirty bits
- // when reading out of the DB.
- friend class URLDatabase;
- friend class HistoryBackend;
-
- // Initializes all values that need initialization to their defaults.
- // This excludes objects which autoinitialize such as strings.
- void Initialize();
-
- // The row ID of this URL from the history database. This is immutable except
- // when retrieving the row from the database or when determining if the URL
- // referenced by the URLRow already exists in the database.
- URLID id_;
-
- // The URL of this row. Immutable except for the database which sets it
- // when it pulls them out. If clients want to change it, they must use
- // the constructor to make a new one.
- GURL url_;
-
- string16 title_;
-
- // Total number of times this URL has been visited.
- int visit_count_;
-
- // Number of times this URL has been manually entered in the URL bar.
- int typed_count_;
-
- // The date of the last visit of this URL, which saves us from having to
- // loop up in the visit table for things like autocomplete and expiration.
- base::Time last_visit_;
-
- // Indicates this entry should now be shown in typical UI or queries, this
- // is usually for subframes.
- bool hidden_;
-
- // We support the implicit copy constuctor and operator=.
-};
-typedef std::vector<URLRow> URLRows;
-
// The enumeration of all possible sources of visits is listed below.
// The source will be propagated along with a URL or a visit item
// and eventually be stored in the history database,
@@ -460,31 +313,6 @@
bool body_only;
};
-// KeywordSearchTermVisit -----------------------------------------------------
-
-// KeywordSearchTermVisit is returned from GetMostRecentKeywordSearchTerms. It
-// gives the time and search term of the keyword visit.
-struct KeywordSearchTermVisit {
- KeywordSearchTermVisit();
- ~KeywordSearchTermVisit();
-
- string16 term; // The search term that was used.
- int visits; // The visit count.
- base::Time time; // The time of the most recent visit.
-};
-
-// KeywordSearchTermRow --------------------------------------------------------
-
-// Used for URLs that have a search term associated with them.
-struct KeywordSearchTermRow {
- KeywordSearchTermRow();
- ~KeywordSearchTermRow();
-
- TemplateURLID keyword_id; // ID of the keyword.
- URLID url_id; // ID of the url.
- string16 term; // The search term that was used.
-};
-
// MostVisitedURL --------------------------------------------------------------
// Holds the per-URL information of the most visited query.
@@ -652,41 +480,6 @@
// AutocompleteAgeThreshold() (or any other desired time in the past).
bool RowQualifiesAsSignificant(const URLRow& row, const base::Time& threshold);
-// Favicons -------------------------------------------------------------------
-
-// Defines the icon types. They are also stored in icon_type field of favicons
-// table.
-// The values of the IconTypes are used to select the priority in which favicon
-// data is returned in HistoryBackend and ThumbnailDatabase. Data for the
-// largest IconType takes priority if data for multiple IconTypes is available.
-enum IconType {
- INVALID_ICON = 0x0,
- FAVICON = 1 << 0,
- TOUCH_ICON = 1 << 1,
- TOUCH_PRECOMPOSED_ICON = 1 << 2
-};
-
-// Used for the mapping between the page and icon.
-struct IconMapping {
- IconMapping();
- ~IconMapping();
-
- // The unique id of the mapping.
- IconMappingID mapping_id;
-
- // The url of a web page.
- GURL page_url;
-
- // The unique id of the icon.
- FaviconID icon_id;
-
- // The url of the icon.
- GURL icon_url;
-
- // The type of icon.
- IconType icon_type;
-};
-
// Defines a favicon bitmap which best matches the desired DIP size and one of
// the desired scale factors.
struct FaviconBitmapResult {
« no previous file with comments | « chrome/browser/history/history_notifications.h ('k') | chrome/browser/history/history_types.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698