Pickling traits for more simple WebKit types.

Pickling traits for more simple WebKit types.

This adds param_traits for WebTransformationMatrix, WebData and some
simple coordinate types.  These will be useful to serialize
ubercompositor frames.

BUG=123447
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157818

[aelias_OOO_until_Jul13, 2012-09-19 22:24:23]

This is some initial pickling stuff for the basic data types we'll need.  My
thinking is that a WebData will be what's sent through the IPC system (i.e.
WebCompositorFrame would be a typedef to it).  The other data types will be
useful to pre-serialize into a WebData object.  In any case, it can't hurt to
add these basic picklers to the codebase.

[piman, 2012-09-19 22:43:09]

LGTM+nits, however adding jam@ for non-trivial changes to content/public.

https://codereview.chromium.org/10948044/diff/1/content/public/common/webkit_...
File content/public/common/webkit_param_traits.cc (right):

https://codereview.chromium.org/10948044/diff/1/content/public/common/webkit_...
content/public/common/webkit_param_traits.cc:42: m->WriteData(p.data(),
static_cast<int>(p.size()));
nit: Why the static cast?

https://codereview.chromium.org/10948044/diff/1/content/public/common/webkit_...
content/public/common/webkit_param_traits.cc:48: const char *data;
nit: = NULL;

[aelias_OOO_until_Jul13, 2012-09-19 22:49:21]

https://codereview.chromium.org/10948044/diff/1/content/public/common/webkit_...
File content/public/common/webkit_param_traits.cc (right):

https://codereview.chromium.org/10948044/diff/1/content/public/common/webkit_...
content/public/common/webkit_param_traits.cc:42: m->WriteData(p.data(),
static_cast<int>(p.size()));
On 2012/09/19 22:43:09, piman wrote:
> nit: Why the static cast?

I based this off ParamTraits<std::vector<char> > in ipc/ipc_message_utils.cc and
that had the static_cast.  But I agree it serves no purpose, removed.

https://codereview.chromium.org/10948044/diff/1/content/public/common/webkit_...
content/public/common/webkit_param_traits.cc:48: const char *data;
On 2012/09/19 22:43:09, piman wrote:
> nit: = NULL;

Done.

[piman, 2012-09-19 22:53:32]

lgtm

[jam, 2012-09-20 06:49:44]

lgtm

[commit-bot: I haz the power, 2012-09-20 17:14:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aelias@chromium.org/10948044/5001

[commit-bot: I haz the power, 2012-09-20 19:40:57]

Change committed as 157818