Issue 10948037: [gtk] fix theming of content settings bubble

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10948037: [gtk] fix theming of content settings bubble (Closed)

Created:
8 years, 3 months ago by Evan Stade

Modified:
8 years, 3 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[gtk] fix theming of content settings bubble BUG=none TEST=block images on a site, click on the image icon in omnibox. Bubble should look normal even when your system theme is light-on-dark, and chrome's in classic theme mode. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157951

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -13 lines)			Patch
M	chrome/browser/ui/gtk/content_setting_bubble_gtk.cc	View	6 chunks	+17 lines, -10 lines	0 comments	Download
M	chrome/browser/ui/gtk/gtk_theme_service.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/gtk_theme_service.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/10948037/1

8 years, 3 months ago (2012-09-20 09:42:20 UTC) #3

commit-bot: I haz the power

8 years, 3 months ago (2012-09-20 18:47:08 UTC) #4

The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is win_rel, revision is HEAD

Expand Messages | Collapse Messages