Issue 10948016: Use utf8 encoding for .AddIn.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10948016: Use utf8 encoding for .AddIn. (Closed)

Created:
8 years, 3 months ago by Sam Clegg

Modified:
8 years, 3 months ago

Reviewers:
noelallen1, binji

CC:
native-client-reviews_googlegroups.com

Base URL:
http://nativeclient-sdk.googlecode.com/svn/trunk/src

Visibility:
Public.

More Reviews

Description

Use utf8 encoding for .AddIn. UTF16 doesn't play will with git and other unix tools. BUG= Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1417

Patch Set 1 #

Total comments: 1

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	visual_studio/NativeClientVSAddIn/InstallerResources/NativeClientVSAddIn.AddIn	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
	M	visual_studio/NativeClientVSAddIn/create_package.py	View		1 chunk	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Sam Clegg

Case in point: code review is unable to show you the diffs correctly for the ...

8 years, 3 months ago (2012-09-18 21:20:51 UTC) #1

noelallen1

8 years, 3 months ago (2012-09-18 23:05:22 UTC) #2

lgtm

http://codereview.chromium.org/10948016/diff/1/visual_studio/NativeClientVSAd...
File visual_studio/NativeClientVSAddIn/create_package.py (right):

http://codereview.chromium.org/10948016/diff/1/visual_studio/NativeClientVSAd...
visual_studio/NativeClientVSAddIn/create_package.py:13: import codecs
Do you still need this?

Expand Messages | Collapse Messages