pylib/gyp/generator/msvs.py - Issue 10948014: Allow library entries of the form '-lfoo' on MSVS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pylib/gyp/generator/msvs.py

Issue 10948014: Allow library entries of the form '-lfoo' on MSVS. (Closed) Base URL: https://gyp.googlecode.com/svn/trunk

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pylib/gyp/generator/msvs.py

diff --git a/pylib/gyp/generator/msvs.py b/pylib/gyp/generator/msvs.py

index e85acd832d56faf26d3949dd3f9adfb84c78e528..96ccfaeb32f0bca24c08ea410b2236e0a5817e56 100644

--- a/pylib/gyp/generator/msvs.py

+++ b/pylib/gyp/generator/msvs.py

@@ -1124,6 +1124,8 @@ def _GetLibraries(spec):

unique_libraries_list = []

for entry in reversed(libraries):

library = re.sub('^\-l', '', entry)

+ if not os.path.splitext(library)[1]:

+ library += '.lib'

if library not in found:

found.add(library)

unique_libraries_list.append(library)

« no previous file with comments | « no previous file | pylib/gyp/generator/msvs_test.py » ('j') | no next file with comments »