Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Unified Diff: lib/coreimpl/date.dart

Issue 10948009: Revert 12494. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/coreimpl/corelib_impl_sources.gypi ('k') | lib/coreimpl/duration_implementation.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/coreimpl/date.dart
===================================================================
--- lib/coreimpl/date.dart (revision 12500)
+++ lib/coreimpl/date.dart (working copy)
@@ -62,7 +62,7 @@
static const int _MAX_MILLISECONDS_SINCE_EPOCH = 8640000000000000;
DateImplementation.fromMillisecondsSinceEpoch(this.millisecondsSinceEpoch,
- this.isUtc) {
+ [this.isUtc = false]) {
if (millisecondsSinceEpoch.abs() > _MAX_MILLISECONDS_SINCE_EPOCH) {
throw new IllegalArgumentException(millisecondsSinceEpoch);
}
@@ -159,15 +159,14 @@
return new Duration(milliseconds: ms - otherMs);
}
- // TODO(lrn): Make parameters not optional for the implementation class.
external DateImplementation(int year,
- [int month = 1,
- int day = 1,
- int hour = 0,
- int minute = 0,
- int second = 0,
- int millisecond = 0,
- bool isUtc = false]);
+ [int month,
+ int day,
+ int hour,
+ int minute,
+ int second,
+ int millisecond,
+ bool isUtc]);
external DateImplementation.now();
external static int _brokenDownDateToMillisecondsSinceEpoch(
int years, int month, int day, int hour, int minute, int second,
« no previous file with comments | « lib/coreimpl/corelib_impl_sources.gypi ('k') | lib/coreimpl/duration_implementation.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698