Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2602)

Unified Diff: chrome/browser/browsing_data/browsing_data_quota_helper_impl.cc

Issue 10948006: Cleanup: quota::HostQuotaCallback do not need to pass host and type as arguments (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed unittests somehow missed in previous patch Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data/browsing_data_quota_helper_impl.cc
diff --git a/chrome/browser/browsing_data/browsing_data_quota_helper_impl.cc b/chrome/browser/browsing_data/browsing_data_quota_helper_impl.cc
index 11b50da22d1d2318482f4f5338d7e579801cde11..31d5be8e4447f44d01b2ee4d40f12bc79ca135df 100644
--- a/chrome/browser/browsing_data/browsing_data_quota_helper_impl.cc
+++ b/chrome/browser/browsing_data/browsing_data_quota_helper_impl.cc
@@ -50,7 +50,8 @@ void BrowsingDataQuotaHelperImpl::RevokeHostQuota(const std::string& host) {
quota_manager_->SetPersistentHostQuota(
host, 0,
base::Bind(&BrowsingDataQuotaHelperImpl::DidRevokeHostQuota,
kinuko 2012/09/18 12:03:56 DidRevokeHostQuota doesn't seem to check host or t
calvinlo 2012/09/19 03:15:38 Done.
- weak_factory_.GetWeakPtr()));
+ weak_factory_.GetWeakPtr(), host,
+ quota::kStorageTypePersistent));
}
BrowsingDataQuotaHelperImpl::BrowsingDataQuotaHelperImpl(
@@ -125,7 +126,7 @@ void BrowsingDataQuotaHelperImpl::GetHostUsage(const std::string& host,
quota_manager_->GetHostUsage(
host, type,
base::Bind(&BrowsingDataQuotaHelperImpl::GotHostUsage,
- weak_factory_.GetWeakPtr()));
+ weak_factory_.GetWeakPtr(), host, type));
}
void BrowsingDataQuotaHelperImpl::GotHostUsage(const std::string& host,
@@ -174,8 +175,8 @@ void BrowsingDataQuotaHelperImpl::OnComplete() {
}
void BrowsingDataQuotaHelperImpl::DidRevokeHostQuota(
- quota::QuotaStatusCode status_unused,
const std::string& host_unused,
quota::StorageType type_unused,
+ quota::QuotaStatusCode status_unused,
int64 quota_unused) {
}

Powered by Google App Engine
This is Rietveld 408576698