Cleanup: quota::HostQuotaCallback do not need to pass host and type as arguments

Cleanup: quota::HostQuotaCallback do not need to pass host and type as arguments

BUG=148900
TBR=jam@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157746

[calvinlo, 2012-09-18 11:24:54]

I think this is ready for review. As discussed in person, I will try to merge
HostQuotaCallback and QuotaCallback in the next patch. Try jobs for this CL also
started.

[kinuko, 2012-09-18 12:03:56]

(Still looking)

Can you update this CL relative to the branch for your another CL (10916313) so
that the CL only contains the diff from it?

$ git cl upload <branch-for-10916313>

Also please run try jobs for the other CL (if you haven't).

https://codereview.chromium.org/10948006/diff/11001/chrome/browser/browsing_d...
File chrome/browser/browsing_data/browsing_data_quota_helper_impl.cc (right):

https://codereview.chromium.org/10948006/diff/11001/chrome/browser/browsing_d...
chrome/browser/browsing_data/browsing_data_quota_helper_impl.cc:52:
base::Bind(&BrowsingDataQuotaHelperImpl::DidRevokeHostQuota,
DidRevokeHostQuota doesn't seem to check host or type. It looks like we can
remove the args from DidRevokeHostQuota and we do not need to bind them for it.

https://codereview.chromium.org/10948006/diff/11001/content/browser/renderer_...
File content/browser/renderer_host/quota_dispatcher_host.cc (right):

https://codereview.chromium.org/10948006/diff/11001/content/browser/renderer_...
content/browser/renderer_host/quota_dispatcher_host.cc:168:
weak_factory_.GetWeakPtr(), host_, type_));
Ditto.  Maybe there's no need to bind them here

[calvinlo, 2012-09-19 03:15:38]

Just FYI, Try jobs aren't running correctly since this is branched from my other
pending patch.

https://codereview.chromium.org/10948006/diff/11001/chrome/browser/browsing_d...
File chrome/browser/browsing_data/browsing_data_quota_helper_impl.cc (right):

https://codereview.chromium.org/10948006/diff/11001/chrome/browser/browsing_d...
chrome/browser/browsing_data/browsing_data_quota_helper_impl.cc:52:
base::Bind(&BrowsingDataQuotaHelperImpl::DidRevokeHostQuota,
On 2012/09/18 12:03:56, kinuko wrote:
> DidRevokeHostQuota doesn't seem to check host or type. It looks like we can
> remove the args from DidRevokeHostQuota and we do not need to bind them for
it.

Done.

https://codereview.chromium.org/10948006/diff/11001/content/browser/renderer_...
File content/browser/renderer_host/quota_dispatcher_host.cc (right):

https://codereview.chromium.org/10948006/diff/11001/content/browser/renderer_...
content/browser/renderer_host/quota_dispatcher_host.cc:168:
weak_factory_.GetWeakPtr(), host_, type_));
On 2012/09/18 12:03:56, kinuko wrote:
> Ditto.  Maybe there's no need to bind them here

Done.

[kinuko, 2012-09-19 09:29:24]

lgtm

http://codereview.chromium.org/10948006/diff/7003/webkit/quota/quota_types.h
File webkit/quota/quota_types.h (right):

http://codereview.chromium.org/10948006/diff/7003/webkit/quota/quota_types.h#...
webkit/quota/quota_types.h:51: int64 quota)> HostQuotaCallback;
nit: can you add a TODO comment to note that we should probably rename this to
QuotaCallback and eventually merge it into the 'original' QuotaCallback?

[calvinlo, 2012-09-19 11:20:51]

Running try jobs again now. Should be ok after commit of previous patch this was
branched from.

http://codereview.chromium.org/10948006/diff/7003/webkit/quota/quota_types.h
File webkit/quota/quota_types.h (right):

http://codereview.chromium.org/10948006/diff/7003/webkit/quota/quota_types.h#...
webkit/quota/quota_types.h:51: int64 quota)> HostQuotaCallback;
On 2012/09/19 09:29:24, kinuko wrote:
> nit: can you add a TODO comment to note that we should probably rename this to
> QuotaCallback and eventually merge it into the 'original' QuotaCallback?

Done.

[kinuko, 2012-09-20 04:47:51]

On 2012/09/19 11:20:51, calvinlo wrote:
> Running try jobs again now. Should be ok after commit of previous patch this
was
> branched from.

Can you run try jobs again?

The try bots try to patch to lkgr version
(http://dev.chromium.org/developers/how-tos/get-the-code#TOC-LKGR) so if your
change depends on another change that is just submitted you'll want to force try
bots to use a specific version by:

$ git cl try --revision=<revision>

Also see: 
http://dev.chromium.org/developers/testing/try-server-usage#TOC-Troubleshooti...

> http://codereview.chromium.org/10948006/diff/7003/webkit/quota/quota_types.h
> File webkit/quota/quota_types.h (right):
> 
>
http://codereview.chromium.org/10948006/diff/7003/webkit/quota/quota_types.h#...
> webkit/quota/quota_types.h:51: int64 quota)> HostQuotaCallback;
> On 2012/09/19 09:29:24, kinuko wrote:
> > nit: can you add a TODO comment to note that we should probably rename this
to
> > QuotaCallback and eventually merge it into the 'original' QuotaCallback?
> 
> Done.

[calvinlo, 2012-09-20 05:59:34]

Hi mkwst, can you please review the small changes in
chrome/browser/browsing_data/

[Mike West, 2012-09-20 06:08:46]

On 2012/09/20 05:59:34, calvinlo wrote:
> Hi mkwst, can you please review the small changes in
> chrome/browser/browsing_data/

browsing_data LGTM.

[calvinlo, 2012-09-20 08:37:20]

I think I've fixed the compile errors I missed before and also the couple of
broken tests. Try jobs running again now.

[commit-bot: I haz the power, 2012-09-20 09:22:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/calvinlo@chromium.org/10948006/24003

[commit-bot: I haz the power, 2012-09-20 09:23:02]

Presubmit check for 10948006-24003 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    content/browser/renderer_host

[calvinlo, 2012-09-20 09:43:45]

Hi Jam, can you please review the minmial change in 
content/browser/renderer_host/. Thanks.

[commit-bot: I haz the power, 2012-09-20 09:43:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/calvinlo@chromium.org/10948006/24003

[commit-bot: I haz the power, 2012-09-20 11:51:58]

Change committed as 157746