Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 1094793004: GN: Fix gn gen/compile errors for MIPS (Closed)

Created:
5 years, 8 months ago by gordanac
Modified:
5 years, 8 months ago
Reviewers:
Dirk Pranke, Lucas Dixon, ldixon, gordana.cmiljanovic
CC:
chromium-reviews, petar.jovanovic, Paul Lind
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Fix gn gen/compile errors for MIPS Fixing two errors: - ERROR Unresolved dependencies. //:gn_only(//build/toolchain/linux:mipsel) needs //third_party/libjpeg_turbo:simd_asm(//build/toolchain/linux:mipsel) by including //third_party/libjpeg_turbo:simd_asm target only for x86 and x64, where it exists - incompatible pointer types in usrsctp by ignoring warnings for this module TEST=gn gen out/mips-linux --args="is_debug=false target_os=\"linux\" target_cpu=\"mipsel\" is_clang=false" ninja -C out/mips-linux/ chrome Committed: https://crrev.com/85746ff1e58b5695f15e61ff5fde46c64d22b4ca Cr-Commit-Position: refs/heads/master@{#327245}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M BUILD.gn View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/usrsctp/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (6 generated)
gordanac
Please take a look. gn gen error can be seen at [1]. [1] http://www.rt-rk.com/mips-buildbot/builders/Chromium_linux_GN/builds/226/steps/Build%20all/logs/stdio
5 years, 8 months ago (2015-04-23 16:25:32 UTC) #2
ldixon
lgtm I don't know much about gn; but it looks like a minor change and ...
5 years, 8 months ago (2015-04-23 17:43:58 UTC) #4
Dirk Pranke
lgtm
5 years, 8 months ago (2015-04-23 22:18:47 UTC) #5
Dirk Pranke
Cool, I didn't realize y'all had your own public buildbot ... Would it be possible ...
5 years, 8 months ago (2015-04-23 22:22:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1094793004/1
5 years, 8 months ago (2015-04-24 09:07:59 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/58758)
5 years, 8 months ago (2015-04-24 09:13:40 UTC) #10
gordanac
On 2015/04/24 09:13:40, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 8 months ago (2015-04-24 09:58:26 UTC) #12
gordanac
On 2015/04/24 09:58:26, gordanac wrote: > On 2015/04/24 09:13:40, I haz the power (commit-bot) wrote: ...
5 years, 8 months ago (2015-04-27 17:28:53 UTC) #13
Lucas Dixon
On 2015/04/27 17:28:53, gordanac wrote: > On 2015/04/24 09:58:26, gordanac wrote: > > On 2015/04/24 ...
5 years, 8 months ago (2015-04-27 20:46:49 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1094793004/1
5 years, 8 months ago (2015-04-28 08:02:03 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-28 08:17:24 UTC) #17
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/85746ff1e58b5695f15e61ff5fde46c64d22b4ca Cr-Commit-Position: refs/heads/master@{#327245}
5 years, 8 months ago (2015-04-28 08:18:19 UTC) #18
gordanac
5 years, 8 months ago (2015-04-28 08:39:02 UTC) #19
Message was sent while issue was closed.
On 2015/04/27 20:46:49, Lucas Dixon wrote:
> On 2015/04/27 17:28:53, gordanac wrote:
> > On 2015/04/24 09:58:26, gordanac wrote:
> > > On 2015/04/24 09:13:40, I haz the power (commit-bot) wrote:
> > > > Try jobs failed on following builders:
> > > >   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
> > > >
> > >
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
> > > 
> > > @ldixon, 
> > > presubmit check failed, I think I need approval from your @chromium.com
> > address.
> > 
> > @ldixon, 
> > just a friendly ping.
> 
> LGTM (although I'm not sure I've the privileges you need... if I don't, I
think
> mailto:pthatcher@chromium.org does )

Thank you, you are in OWNERS list :)

Powered by Google App Engine
This is Rietveld 408576698