Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Unified Diff: media/base/pipeline.h

Issue 1094783002: Switch to double for time calculations using playback rate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Making changes at chromecast side to fix trybots Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/mock_filters.h ('k') | media/base/pipeline.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/pipeline.h
diff --git a/media/base/pipeline.h b/media/base/pipeline.h
index 30707b3c329303bc7664f632f8741d79c9e36ae2..28b30836da6ddce87054b15c1323ee8005db02f7 100644
--- a/media/base/pipeline.h
+++ b/media/base/pipeline.h
@@ -144,17 +144,17 @@ class MEDIA_EXPORT Pipeline : public DemuxerHost {
bool IsRunning() const;
// Gets the current playback rate of the pipeline. When the pipeline is
- // started, the playback rate will be 0.0f. A rate of 1.0f indicates
+ // started, the playback rate will be 0.0. A rate of 1.0 indicates
// that the pipeline is rendering the media at the standard rate. Valid
- // values for playback rate are >= 0.0f.
- float GetPlaybackRate() const;
+ // values for playback rate are >= 0.0.
+ double GetPlaybackRate() const;
- // Attempt to adjust the playback rate. Setting a playback rate of 0.0f pauses
- // all rendering of the media. A rate of 1.0f indicates a normal playback
- // rate. Values for the playback rate must be greater than or equal to 0.0f.
+ // Attempt to adjust the playback rate. Setting a playback rate of 0.0 pauses
+ // all rendering of the media. A rate of 1.0 indicates a normal playback
+ // rate. Values for the playback rate must be greater than or equal to 0.0.
//
// TODO(scherkus): What about maximum rate? Does HTML5 specify a max?
- void SetPlaybackRate(float playback_rate);
+ void SetPlaybackRate(double playback_rate);
// Gets the current volume setting being used by the audio renderer. When
// the pipeline is started, this value will be 1.0f. Valid values range
@@ -245,7 +245,7 @@ class MEDIA_EXPORT Pipeline : public DemuxerHost {
void ErrorChangedTask(PipelineStatus error);
// Carries out notifying filters that the playback rate has changed.
- void PlaybackRateChangedTask(float playback_rate);
+ void PlaybackRateChangedTask(double playback_rate);
// Carries out notifying filters that the volume has changed.
void VolumeChangedTask(float volume);
@@ -322,10 +322,10 @@ class MEDIA_EXPORT Pipeline : public DemuxerHost {
// filters.
float volume_;
- // Current playback rate (>= 0.0f). This value is set immediately via
+ // Current playback rate (>= 0.0). This value is set immediately via
// SetPlaybackRate() and a task is dispatched on the task runner to notify
// the filters.
- float playback_rate_;
+ double playback_rate_;
// Current duration as reported by |demuxer_|.
base::TimeDelta duration_;
« no previous file with comments | « media/base/mock_filters.h ('k') | media/base/pipeline.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698