media/mojo/interfaces/media_renderer.mojom - Issue 1094783002: Switch to double for time calculations using playback rate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/mojo/interfaces/media_renderer.mojom

Issue 1094783002: Switch to double for time calculations using playback rate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporating review comments(replacing all float playback_rate to double.) Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/mojo/interfaces/media_renderer.mojom

diff --git a/media/mojo/interfaces/media_renderer.mojom b/media/mojo/interfaces/media_renderer.mojom

index 9165a338cd80b8249bbe782b1a9322c1f868ab46..616e6770f72122c1c66fc133ca1f2affe94120a3 100644

--- a/media/mojo/interfaces/media_renderer.mojom

+++ b/media/mojo/interfaces/media_renderer.mojom

@@ -25,7 +25,7 @@ interface MediaRenderer {

StartPlayingFrom(int64 time_usec);

// Updates the current playback rate. The default playback rate should be 1.

- SetPlaybackRate(float playback_rate);

+ SetPlaybackRate(double playback_rate);

// Sets the output volume. The default volume should be 1.

SetVolume(float volume);

« media/base/pipeline_unittest.cc ('K') | « media/filters/audio_renderer_algorithm_unittest.cc ('k') | media/mojo/services/mojo_renderer_impl.h » ('j') | no next file with comments »