Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(915)

Unified Diff: media/base/pipeline.h

Issue 1094783002: Switch to double for time calculations using playback rate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporating review comments(replacing all float playback_rate to double.) Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/pipeline.h
diff --git a/media/base/pipeline.h b/media/base/pipeline.h
index 30707b3c329303bc7664f632f8741d79c9e36ae2..ba4ecfeed20a819918cf5a7c47b7d1acedecc27f 100644
--- a/media/base/pipeline.h
+++ b/media/base/pipeline.h
@@ -154,7 +154,7 @@ class MEDIA_EXPORT Pipeline : public DemuxerHost {
// rate. Values for the playback rate must be greater than or equal to 0.0f.
//
// TODO(scherkus): What about maximum rate? Does HTML5 specify a max?
- void SetPlaybackRate(float playback_rate);
+ void SetPlaybackRate(double playback_rate);
// Gets the current volume setting being used by the audio renderer. When
// the pipeline is started, this value will be 1.0f. Valid values range
@@ -245,7 +245,7 @@ class MEDIA_EXPORT Pipeline : public DemuxerHost {
void ErrorChangedTask(PipelineStatus error);
// Carries out notifying filters that the playback rate has changed.
- void PlaybackRateChangedTask(float playback_rate);
+ void PlaybackRateChangedTask(double playback_rate);
// Carries out notifying filters that the volume has changed.
void VolumeChangedTask(float volume);
@@ -325,7 +325,7 @@ class MEDIA_EXPORT Pipeline : public DemuxerHost {
// Current playback rate (>= 0.0f). This value is set immediately via
// SetPlaybackRate() and a task is dispatched on the task runner to notify
// the filters.
- float playback_rate_;
+ double playback_rate_;
// Current duration as reported by |demuxer_|.
base::TimeDelta duration_;

Powered by Google App Engine
This is Rietveld 408576698