Remove custom signatures from V8 bindings

Source/bindings/scripts/code_generator_v8.pm

 # Copyright (C) 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org>
 # Copyright (C) 2006 Anders Carlsson <andersca@mac.com>
 # Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
 # Copyright (C) 2006 Alexey Proskuryakov <ap@webkit.org>
 # Copyright (C) 2006 Apple Computer, Inc.
 # Copyright (C) 2007, 2008, 2009, 2012 Google Inc.
 # Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
 # Copyright (C) Research In Motion Limited 2010. All rights reserved.
 # Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
 # Copyright (C) 2012 Ericsson AB. All rights reserved.
@@ skipping 3359 matching lines @@
 {
     my $interface = shift;
     my $function = shift;
 
     my $interfaceName = $interface->name;
     my $attrExt = $function->extendedAttributes;
     return 0 if $attrExt->{"Unforgeable"};
     return 0 if $function->isStatic;
     return 0 if $attrExt->{"RuntimeEnabled"};
     return 0 if $attrExt->{"PerContextEnabled"};
-    return 0 if RequiresCustomSignature($function);
     return 0 if $attrExt->{"DoNotCheckSignature"};
     return 0 if ($attrExt->{"DoNotCheckSecurity"} && ($interface->extendedAttributes->{"CheckSecurity"} || $interfaceName eq "Window"));
     return 0 if $attrExt->{"NotEnumerable"};
     return 0 if $attrExt->{"ReadOnly"};
     return 1;
 }
 
 sub GenerateNonStandardFunction
 {
     my $interface = shift;
@@ skipping 57 matching lines @@
         return $code;
     }
 
     my $signature = "defaultSignature";
     if ($attrExt->{"DoNotCheckSignature"} || $function->isStatic) {
        $signature = "v8::Local<v8::Signature>()";
     }
 
     my $conditionalString = GenerateConditionalString($function);
     $code .= "#if ${conditionalString}\n" if $conditionalString;
-    if (RequiresCustomSignature($function)) {
-        $signature = "${name}Signature";
-        $code .= "\n    // Custom Signature '$name'\n" . CreateCustomSignature($function);
-    }
 
     if ($property_attributes eq "v8::DontDelete") {
         $property_attributes = "";
     } else {
         $property_attributes = ", static_cast<v8::PropertyAttribute>($property_attributes)";
     }
 
     if ($template eq "prototypeTemplate" && $conditional4 eq "" && $signature eq "defaultSignature" && $property_attributes eq "") {
         die "This shouldn't happen: Class '$implClassName' $commentInfo\n";
     }
@@ skipping 2024 matching lines @@
 
     if ($type eq "Promise") {
         AddToImplIncludes("bindings/v8/ScriptPromise.h");
         return "ScriptPromise($value)";
     }
 
     if ($type eq "NodeFilter") {
         return "toNodeFilter($value, $getIsolate)";
     }
 
+    if ($type eq "Window") {
+        return "toNativeDOMWindow($value, $getIsolate)";
+    }
+
     if ($type eq "MediaQueryListListener") {
         AddToImplIncludes("core/css/MediaQueryListListener.h");
         return "MediaQueryListListener::create(ScriptValue(" . $value . ", $getIsolate))";
     }
 
     if ($type eq "EventTarget") {
         return "V8DOMWrapper::isDOMWrapper($value) ? toWrapperTypeInfo(v8::Handle<v8::Object>::Cast($value))->toEventTarget(v8::Handle<v8::Object>::Cast($value)) : 0";
     }
 
     if (IsTypedArrayType($type)) {
@@ skipping 14 matching lines @@
         }
         return "toNativeArray<" . GetNativeType($arrayOrSequenceType) . ">($value, $argIndexOrZero, $getIsolate)";
     }
 
     AddIncludesForType($type);
 
     AddToImplIncludes("V8${type}.h");
     return "V8${type}::hasInstance($value, $getIsolate, worldType($getIsolate)) ? V8${type}::toNative(v8::Handle<v8::Object>::Cast($value)) : 0";
 }
 
-sub CreateCustomSignature
-{
-    my $function = shift;
-    my $count = @{$function->parameters};
-    my $name = $function->name;
-    my $code = "    const int ${name}Argc = ${count};\n" .
-      "    v8::Handle<v8::FunctionTemplate> ${name}Argv[${name}Argc] = { ";
-    my $first = 1;
-    foreach my $parameter (@{$function->parameters}) {
-        if ($first) { $first = 0; }
-        else { $code .= ", "; }
-        if (IsWrapperType($parameter->type) && not IsTypedArrayType($parameter->type)) {
-            if ($parameter->type eq "XPathNSResolver") {
-                # Special case for XPathNSResolver.  All other browsers accepts a callable,
-                # so, even though it's against IDL, accept objects here.
-                $code .= "v8::Handle<v8::FunctionTemplate>()";
-            } else {
-                my $type = $parameter->type;
-                my $arrayOrSequenceType = GetArrayOrSequenceType($type);
-
-                if ($arrayOrSequenceType) {
-                    if (IsRefPtrType($arrayOrSequenceType)) {
-                        AddIncludesForType($arrayOrSequenceType);
-                    } else {
-                        $code .= "v8::Handle<v8::FunctionTemplate>()";
-                        next;
-                    }
-                } else {
-                    AddIncludesForType($type);
-                }
-                $code .= "V8PerIsolateData::from(isolate)->rawDOMTemplate(&V8${type}::wrapperTypeInfo, currentWorldType)";
-            }
-        } else {
-            $code .= "v8::Handle<v8::FunctionTemplate>()";
-        }
-    }
-    $code .= " };\n";
-    $code .= "    v8::Handle<v8::Signature> ${name}Signature = v8::Signature::New(isolate, functionTemplate, ${name}Argc, ${name}Argv);\n";
-    return $code;
-}
-
-
-sub RequiresCustomSignature
-{
-    my $function = shift;
-    # No signature needed for Custom function
-    if (HasCustomMethod($function->extendedAttributes)) {
-        return 0;
-    }
-    # No signature needed for overloaded function
-    if (@{$function->{overloads}} > 1) {
-        return 0;
-    }
-    if ($function->isStatic) {
-        return 0;
-    }
-    # Type checking is performed in the generated code
-    if ($function->extendedAttributes->{"StrictTypeChecking"}) {
-      return 0;
-    }
-    foreach my $parameter (@{$function->parameters}) {
-        if (($parameter->isOptional && !$parameter->extendedAttributes->{"Default"}) || IsCallbackInterface($parameter->type)) {
-            return 0;
-        }
-    }
-
-    foreach my $parameter (@{$function->parameters}) {
-        if (IsWrapperType($parameter->type)) {
-            return 1;
-        }
-    }
-    return 0;
-}
-
 sub IsUnionType
 {
     my $type = shift; # string or UnionType
     if(ref($type) eq "UnionType") {
         die "Currently only 2 values of non-union type is supported as union type.\n" unless @{$type->unionMemberTypes} == 2;
         return 1;
     }
     return 0;
 }
 
@@ skipping 758 matching lines @@
 
     foreach my $parameter (@{$function->parameters}) {
         if ($parameter->type eq "SerializedScriptValue") {
             return 1;
         }
     }
     return 0;
 }
 
 1;