Supress the two noisiest warnings on linux standalone builds.

Supress the two noisiest warnings on linux standalone builds.

Code might someday be made clean for -Wmissing-field-initializers
and -Wsign-compare, but for now this produces too much noise to be
useful.

The -Wmissing-field-initializers warning is misguided in a high
percentage of cases, and actually leads to bad fixes.

R=brucedawson@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/269aaa26f33891f42934fa4f3e4ca3e320018a21

[Tom Sepez, 2015-04-16 20:48:52]

tsepez@chromium.org changed reviewers:
+ brucedawson@chromium.org

[Tom Sepez, 2015-04-16 20:49:27]

Bruce, as long as we're mucking with this, let me add two long overdue
suppressions on my side.

[brucedawson, 2015-04-16 20:54:24]

lgtm

My only suggestion would be perhaps changing the comment and perhaps not
planning to reinstate one or both of the warnings.

https://codereview.chromium.org/1094713002/diff/1/build/standalone.gypi
File build/standalone.gypi (right):

https://codereview.chromium.org/1094713002/diff/1/build/standalone.gypi#newco...
build/standalone.gypi:147: # Code should someday be made clean for
-Wmissing-field-initializers
I am not convinced that code should ever be made clean for
-Wmissing-field-initializers. Do we try to build Chrome clean for that warning?

I think that that warning is misguided in a high percentage of cases, and
actually leads to bad fixes. I don't think we ever want to reinstate it.

We *might* want to reinstate sign-compare. Maybe.

[Tom Sepez, 2015-04-16 20:59:06]

Committed patchset #2 (id:20001) manually as
269aaa26f33891f42934fa4f3e4ca3e320018a21 (presubmit successful).