Issue 10947033: [Android] Make android_webview targets sdk-only.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10947033: [Android] Make android_webview targets sdk-only. (Closed)

Created:
8 years, 3 months ago by mkosiba (inactive)

Modified:
8 years, 3 months ago

Reviewers:
Isaac (away), nilesh

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android] Make android_webview targets sdk-only. These targets are currently only configured to work as part of the SDK build. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157732

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix ordering issue #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	build/all_android.gyp	View	1	4 chunks	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Isaac (away)

lgtm but lets pull in one more, I'm not that familiar with gyp best practices.

8 years, 3 months ago (2012-09-19 20:29:47 UTC) #2

nilesh

On 2012/09/19 20:29:47, Isaac wrote: > lgtm but lets pull in one more, I'm not ...

8 years, 3 months ago (2012-09-19 20:34:40 UTC) #3

nilesh

8 years, 3 months ago (2012-09-19 20:34:46 UTC) #4

https://codereview.chromium.org/10947033/diff/1/build/all_android.gyp
File build/all_android.gyp (right):

https://codereview.chromium.org/10947033/diff/1/build/all_android.gyp#newcode28
build/all_android.gyp:28:
'../android_webview/android_webview.gyp:android_webview_apk',
Nit: Sort order.

Expand Messages | Collapse Messages