Made dart2js constructor lookup logic "private"-aware, fixed 4740 bug.

lib/compiler/implementation/universe/universe.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #library('universe');
 
 #import('../closure.dart');
 #import('../elements/elements.dart');
 #import('../leg.dart');
 #import('../scanner/scannerlib.dart');
@@ skipping 105 matching lines @@
   static const SelectorKind OPERATOR = const SelectorKind('operator');
   static const SelectorKind INDEX = const SelectorKind('index');
 
   toString() => name;
 }
 
 class Selector {
   final SelectorKind kind;
   final SourceString name;
   final LibraryElement library; // Library is null for non-private selectors.
+  final SourceString normalizedConstructorName;

[kasperl, 2012/10/08 08:06:41]

It would indeed be great to get rid of this and use an empty name for default
constructors and the name of the constructor for the others. I'm okay with
trying that out in another CL.

[aam-me, 2012/10/09 04:08:42]

Done.

 
   // The numbers of arguments of the selector. Includes named arguments.
   final int argumentCount;
   final List<SourceString> namedArguments;
   final List<SourceString> orderedNamedArguments;
 
   Selector(
       this.kind,
       SourceString name,
       LibraryElement library,
       this.argumentCount,
-      [List<SourceString> namedArguments = const <SourceString>[]])
+      [List<SourceString> namedArguments = const <SourceString>[],
+      SourceString normalizedConstructorName = null])
     : this.name = name,
       this.library = name.isPrivate() ? library : null,
       this.namedArguments = namedArguments,
       this.orderedNamedArguments = namedArguments.isEmpty()
           ? namedArguments
-          : <SourceString>[] {
+          : <SourceString>[],
+      this.normalizedConstructorName = normalizedConstructorName {
     assert(!name.isPrivate() || library != null);
   }
 
   Selector.getter(SourceString name, LibraryElement library)
       : this(SelectorKind.GETTER, name, library, 0);
 
   Selector.getterFrom(Selector selector)
       : this(SelectorKind.GETTER, selector.name, selector.library, 0);
 
   Selector.setter(SourceString name, LibraryElement library)
@@ skipping 26 matching lines @@
       : this(SelectorKind.CALL, name, library, arity, named);
 
   Selector.callClosure(int arity, [List<SourceString> named = const []])
       : this(SelectorKind.CALL, Compiler.CALL_OPERATOR_NAME, null,
              arity, named);
 
   Selector.callClosureFrom(Selector selector)
       : this(SelectorKind.CALL, Compiler.CALL_OPERATOR_NAME, null,
              selector.argumentCount, selector.namedArguments);
 
+  Selector.callConstructor(SourceString className,
+                           SourceString constructorName,
+                           LibraryElement library)
+      : this(SelectorKind.CALL,
+             constructorName,
+             library,
+             0,
+             const [],
+             Elements.constructConstructorName(className, constructorName));
+
+  Selector.callDefaultConstructor(SourceString name,
+                                  LibraryElement library)
+      : this(SelectorKind.CALL, name, library, 0, const [], name);
+
   // TODO(kasperl): This belongs somewhere else.
   Selector.noSuchMethod()
       : this(SelectorKind.CALL, Compiler.NO_SUCH_METHOD, null, 2);
 
   bool isGetter() => kind === SelectorKind.GETTER;
   bool isSetter() => kind === SelectorKind.SETTER;
   bool isCall() => kind === SelectorKind.CALL;
 
   bool isIndex() => kind === SelectorKind.INDEX && argumentCount == 1;
   bool isIndexSet() => kind === SelectorKind.INDEX && argumentCount == 2;
@@ skipping 325 matching lines @@
 
     if (!self.isInterface() && self.isSubclassOf(other)) {
       // Resolve an invocation of [element.name] on [self]. If it
       // is found, this selector is a candidate.
       return hasElementIn(self, element) && appliesUntyped(element, compiler);
     }
 
     return false;
   }
 }