Made dart2js constructor lookup logic "private"-aware, fixed 4740 bug.

lib/compiler/implementation/elements/elements.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #library('elements');
 
 #import('dart:uri');
 
 #import('../tree/tree.dart');
 #import('../scanner/scannerlib.dart');
@@ skipping 1385 matching lines @@
     }
     SourceString fieldName = fieldMember.name;
     while (true) {
       Element foundMember = lookupClass.lookupMember(fieldName);
       if (foundMember == fieldMember) return false;
       if (foundMember.isField()) return true;
       lookupClass = foundMember.getEnclosingClass().superclass;
     }
   }
 
-  Element lookupConstructor(SourceString className,
-                            [SourceString constructorName =
-                                 const SourceString(''),
-                            Element noMatch(Element)]) {
+  Element lookupConstructor(Selector selector, [Element noMatch(Element)]) {
     // TODO(karlklose): have a map from class names to a map of constructors
     //                  instead of creating the name here?
-    SourceString normalizedName;
-    if (constructorName !== const SourceString('')) {
-      normalizedName = Elements.constructConstructorName(className,
-                                                         constructorName);
-    } else {
-      normalizedName = className;
-    }
-    Element result = localLookup(normalizedName);
-    if (result === null || !result.isConstructor()) {
+    Element result = localLookup(selector.normalizedConstructorName);

[kasperl, 2012/10/08 08:06:41]

Can't you construct the normalized constructor name here from the class name in
[this] ClassElement and the name in the selector? Alternatively, you should
implement your own variant of localLookup that runs through local constructors
(guaranteed to be on the right class) and see if the name in the selector
matches?

[aam-me, 2012/10/09 04:08:42]

Thanks for the tips. I gave it a try.

+    if (result === null
+        || !result.isConstructor()
+        || (selector.name.isPrivate()
+            && result.getLibrary() != selector.library)) {
       result = noMatch !== null ? noMatch(result) : null;
     }
     return result;
   }
 
   bool get hasConstructor {
     // Search in scope to be sure we search patched constructors.
     for (var element in localScope.getValues()) {
       if (element.isConstructor()) return true;
     }
@@ skipping 442 matching lines @@
 
   MetadataAnnotation ensureResolved(Compiler compiler) {
     if (resolutionState == STATE_NOT_STARTED) {
       compiler.resolver.resolveMetadataAnnotation(this);
     }
     return this;
   }
 
   String toString() => 'MetadataAnnotation($value, $resolutionState)';
 }