Issue 10947005: Set user agent in cpp bindings test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10947005: Set user agent in cpp bindings test (Closed)

Created:
8 years, 3 months ago by jochen (gone - plz use gerrit)

Modified:
8 years, 3 months ago

Reviewers:
tony, Nico

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Set user agent in cpp bindings test It asserts on mac when it's not set BUG=150069 TEST=manual TBR=tony@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157339

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	webkit/glue/cpp_bound_class_unittest.cc	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

jochen (gone - plz use gerrit)

plz review test_shell_tests has the same code, but cpp bound class test directly derives from ...

8 years, 3 months ago (2012-09-18 08:16:33 UTC) #1

Nico

lgtm Do you understand why this wasn't necessary previously?

8 years, 3 months ago (2012-09-18 08:46:51 UTC) #2

jochen (gone - plz use gerrit)

On 2012/09/18 08:46:51, Nico wrote: > lgtm > > Do you understand why this wasn't ...

8 years, 3 months ago (2012-09-18 08:48:29 UTC) #3

tony

8 years, 3 months ago (2012-09-18 17:08:59 UTC) #4

This is correct.  See the explanation from tkent in
https://chromiumcodereview.appspot.com/10938008/ .