Issue 10947: Generate code for choice nodes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10947: Generate code for choice nodes. (Closed)

Created:
12 years, 1 month ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Christian Plesner Hansen

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/experimental/regexp2000/

Visibility:
Public.

Description

Generate code for choice nodes. Committed: http://code.google.com/p/v8/source/detail?r=761

Patch Set 1 #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -5 lines)			Patch
	M	src/jsregexp.h	View		2 chunks	+4 lines, -1 line	1 comment	Download
	M	src/jsregexp.cc	View		2 chunks	+45 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Christian Plesner Hansen

12 years, 1 month ago (2008-11-14 13:28:34 UTC) #2

Lookin' good!

http://codereview.chromium.org/10947/diff/1/2
File src/jsregexp.h (right):

http://codereview.chromium.org/10947/diff/1/2#newcode407
Line 407: Label* GetLabel();
Since this is a simple accessor you could just call it label() and write the
implementation inline.

Expand Messages | Collapse Messages