Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Side by Side Diff: components/nacl/common/nacl_types.cc

Issue 1094653003: Refactor NaClProcessHost. Reduce chances to leak the resource. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/nacl/common/nacl_types.h" 5 #include "components/nacl/common/nacl_types.h"
6 #include "ipc/ipc_platform_file.h" 6 #include "ipc/ipc_platform_file.h"
7 7
8 namespace nacl { 8 namespace nacl {
9 9
10 NaClStartParams::NaClStartParams() 10 NaClStartParams::NaClStartParams()
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 NaClLaunchResult::NaClLaunchResult() 71 NaClLaunchResult::NaClLaunchResult()
72 : imc_channel_handle(IPC::InvalidPlatformFileForTransit()), 72 : imc_channel_handle(IPC::InvalidPlatformFileForTransit()),
73 ppapi_ipc_channel_handle(), 73 ppapi_ipc_channel_handle(),
74 trusted_ipc_channel_handle(), 74 trusted_ipc_channel_handle(),
75 plugin_pid(base::kNullProcessId), 75 plugin_pid(base::kNullProcessId),
76 plugin_child_id(0), 76 plugin_child_id(0),
77 crash_info_shmem_handle(base::SharedMemory::NULLHandle()) { 77 crash_info_shmem_handle(base::SharedMemory::NULLHandle()) {
78 } 78 }
79 79
80 NaClLaunchResult::NaClLaunchResult( 80 NaClLaunchResult::NaClLaunchResult(
81 FileDescriptor imc_channel_handle, 81 const IPC::PlatformFileForTransit& imc_channel_handle,
82 const IPC::ChannelHandle& ppapi_ipc_channel_handle, 82 const IPC::ChannelHandle& ppapi_ipc_channel_handle,
83 const IPC::ChannelHandle& trusted_ipc_channel_handle, 83 const IPC::ChannelHandle& trusted_ipc_channel_handle,
84 const IPC::ChannelHandle& manifest_service_ipc_channel_handle, 84 const IPC::ChannelHandle& manifest_service_ipc_channel_handle,
85 base::ProcessId plugin_pid, 85 base::ProcessId plugin_pid,
86 int plugin_child_id, 86 int plugin_child_id,
87 base::SharedMemoryHandle crash_info_shmem_handle) 87 base::SharedMemoryHandle crash_info_shmem_handle)
88 : imc_channel_handle(imc_channel_handle), 88 : imc_channel_handle(imc_channel_handle),
89 ppapi_ipc_channel_handle(ppapi_ipc_channel_handle), 89 ppapi_ipc_channel_handle(ppapi_ipc_channel_handle),
90 trusted_ipc_channel_handle(trusted_ipc_channel_handle), 90 trusted_ipc_channel_handle(trusted_ipc_channel_handle),
91 manifest_service_ipc_channel_handle(manifest_service_ipc_channel_handle), 91 manifest_service_ipc_channel_handle(manifest_service_ipc_channel_handle),
92 plugin_pid(plugin_pid), 92 plugin_pid(plugin_pid),
93 plugin_child_id(plugin_child_id), 93 plugin_child_id(plugin_child_id),
94 crash_info_shmem_handle(crash_info_shmem_handle) { 94 crash_info_shmem_handle(crash_info_shmem_handle) {
95 } 95 }
96 96
97 NaClLaunchResult::~NaClLaunchResult() { 97 NaClLaunchResult::~NaClLaunchResult() {
98 } 98 }
99 99
100 } // namespace nacl 100 } // namespace nacl
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698