Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(9)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: test/message/formal-parameters-bad-rest.out
Issue
1094653002
:
Revert "Factor formal argument parsing into ParserBase" (Closed)
Base URL: https://chromium.googlesource.com/v8/v8@master
Patch Set:
Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
src/messages.js
src/parser.h
src/parser.cc
src/preparser.h
src/preparser.cc
test/cctest/test-parsing.cc
test/message/formal-parameters-bad-rest.js
test/message/formal-parameters-bad-rest.out
test/message/formal-parameters-strict-body.js
test/message/formal-parameters-strict-body.out
test/message/formal-parameters-trailing-comma.js
test/message/formal-parameters-trailing-comma.out
test/message/strict-formal-parameters.js
test/message/strict-formal-parameters.out
View unified diff
|
Download patch
« no previous file with comments
|
« test/message/formal-parameters-bad-rest.js
('k') |
test/message/formal-parameters-strict-body.js »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
*%(basename)s:7: SyntaxError: Rest parameter must be last formal parameter
2
function foo(...b, a) { return a }
3
^
4
SyntaxError: Rest parameter must be last formal parameter
OLD
NEW
« no previous file with comments
|
« test/message/formal-parameters-bad-rest.js
('k') |
test/message/formal-parameters-strict-body.js »
('j') |
no next file with comments »
Issue 1094653002: Revert "Factor formal argument parsing into ParserBase" (Closed)
Created 5 years, 8 months ago by wingo
Modified 5 years, 8 months ago
Reviewers: marja, rossberg
Base URL: https://chromium.googlesource.com/v8/v8@master
Comments: 0
This is Rietveld
408576698