Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 10946044: Revert 157650 - This is followup from Charlie's comments on Fady's cl: http://chromiumcodereview.ap… (Closed)

Created:
8 years, 3 months ago by Nicolas Zea
Modified:
8 years, 3 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Revert 157650 - This is followup from Charlie's comments on Fady's cl: http://chromiumcodereview.appspot.com/10560022, it seems I cannot upload patch to that issue (since I'm not owner), I'm creating a new one. Introduced too many static initializers - broke linux sizes. Split Embedder and Guest 'roles' for browser plugin, web contents can now play any or both roles, main idea is to have more readable separation between the two. Also stop creating browser_plugin counterpart in browser/host for every web_contents, instead create them only when there's a browser_plugin element. BUG=141232 Review URL: https://chromiumcodereview.appspot.com/10868012 TBR=lazyboy@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157656

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -2360 lines) Patch
M chrome/renderer/chrome_content_renderer_client.cc View 1 chunk +3 lines, -5 lines 0 comments Download
D content/browser/browser_plugin/browser_plugin_embedder.h View 1 chunk +0 lines, -144 lines 0 comments Download
D content/browser/browser_plugin/browser_plugin_embedder.cc View 1 chunk +0 lines, -231 lines 0 comments Download
D content/browser/browser_plugin/browser_plugin_embedder_helper.h View 1 chunk +0 lines, -72 lines 0 comments Download
D content/browser/browser_plugin/browser_plugin_embedder_helper.cc View 1 chunk +0 lines, -151 lines 0 comments Download
D content/browser/browser_plugin/browser_plugin_guest.h View 1 chunk +0 lines, -174 lines 0 comments Download
D content/browser/browser_plugin/browser_plugin_guest.cc View 1 chunk +0 lines, -280 lines 0 comments Download
D content/browser/browser_plugin/browser_plugin_guest_helper.h View 1 chunk +0 lines, -61 lines 0 comments Download
D content/browser/browser_plugin/browser_plugin_guest_helper.cc View 1 chunk +0 lines, -62 lines 0 comments Download
D content/browser/browser_plugin/browser_plugin_host_browsertest.cc View 1 chunk +0 lines, -483 lines 0 comments Download
D content/browser/browser_plugin/browser_plugin_host_factory.h View 1 chunk +0 lines, -40 lines 0 comments Download
D content/browser/browser_plugin/test_browser_plugin_embedder.h View 1 chunk +0 lines, -49 lines 0 comments Download
D content/browser/browser_plugin/test_browser_plugin_embedder.cc View 1 chunk +0 lines, -42 lines 0 comments Download
D content/browser/browser_plugin/test_browser_plugin_guest.h View 1 chunk +0 lines, -90 lines 0 comments Download
D content/browser/browser_plugin/test_browser_plugin_guest.cc View 1 chunk +0 lines, -171 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 2 chunks +1 line, -12 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 1 chunk +0 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 7 chunks +1 line, -29 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 8 chunks +0 lines, -74 lines 0 comments Download
MM content/common/browser_plugin_messages.h View 2 chunks +3 lines, -9 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -9 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.h View 2 chunks +1 line, -9 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.cc View 6 chunks +14 lines, -55 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin_browsertest.cc View 2 chunks +8 lines, -12 lines 0 comments Download
MM content/renderer/browser_plugin/browser_plugin_manager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_main.cc View 2 chunks +0 lines, -2 lines 0 comments Download
D content/test/data/browser_plugin_embedder.html View 1 chunk +0 lines, -18 lines 0 comments Download
D content/test/data/browser_plugin_embedder_crash.html View 1 chunk +0 lines, -17 lines 0 comments Download
D content/test/data/browser_plugin_focus.html View 1 chunk +0 lines, -21 lines 0 comments Download
D content/test/data/browser_plugin_focus_child.html View 1 chunk +0 lines, -6 lines 0 comments Download
D content/test/data/browser_plugin_title_change.html View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nicolas Zea
8 years, 3 months ago (2012-09-19 23:52:55 UTC) #1
lazyboy
8 years, 3 months ago (2012-09-19 23:55:29 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698