Remove Chrome's ProgID from filetype associations at uninstall.

chrome/installer/setup/uninstall.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file defines the methods useful for uninstalling Chrome.
 
 #include "chrome/installer/setup/uninstall.h"
 
 #include <windows.h>
 
@@ skipping 731 matching lines @@
        *proto != NULL;
        ++proto) {
     parent_key.resize(base_length);
     parent_key.push_back(FilePath::kSeparators[0]);
     parent_key.append(*proto);
     child_key.assign(parent_key).append(ShellUtil::kRegShellOpen);
     InstallUtil::DeleteRegistryKeyIf(root, parent_key, child_key, L"",
                                      open_command_pred);
   }
 
+  // Delete each filetype association if it references this Chrome.  Don't
+  // delete the whole key since other apps may have stored data there.
+  InstallUtil::ValueEquals prog_id_pred(prog_id);

[gab, 2012/09/19 16:11:16]

|prog_id| here could be suffixed and unsuffixed (based on the
|browser_entry_suffix| parameter). DeleteChromeRegistrationKeys can be called
with no suffix even when the install present is suffixed (see line 1064 in this
file). So that it's technically possible that this would remove registrations
that are there to make a system-level Chrome default for this user when
uninstalling a user-level install for that same user...

It probably makes sense to only do this extra uninstall step iff |remove_all|.

[grt (UTC plus 2), 2012/09/19 19:43:15]

Great catch.  Updated as discussed.

+  for (const wchar_t* const* filetype = &ShellUtil::kFileAssociations[0];

[gab, 2012/09/19 16:11:16]

I feel this is overly complicated to loop through an array, why not
for (int i = 0; ShellUtil::kFileAssociations[i] != NULL; ++i)
as per shell_util.cc:1339 ?

[grt (UTC plus 2), 2012/09/19 19:43:15]

The size of the array isn't known here as it is in shell_util.cc.

[gab, 2012/09/19 19:58:50]

Hmmm, the suggested code doesn't depend on the size of the array...

[grt (UTC plus 2), 2012/09/19 20:04:52]

Oh, I see.  I read the suggestion as knowing arraysize.  Anyway, I like the
iterator approach rather than the indexing approach, so I'm keeping it.  :-)

+       *filetype != NULL; ++filetype) {
+    parent_key.resize(base_length);
+    parent_key.push_back(FilePath::kSeparators[0]);

[gab, 2012/09/19 16:11:16]

If |parent_key| is always going to have the separator, why not make the
separator part of the base section (i.e. adding it before initializing
|base_length|)?

[grt (UTC plus 2), 2012/09/19 19:43:15]

Done.

+    parent_key.append(*filetype);
+    InstallUtil::DeleteRegistryValueIf(root, parent_key.c_str(), L"",

[gab, 2012/09/19 16:11:16]

optional: I don't like that this method takes wchar_t* only to assert they are
not NULL... I would prefer if it would take string16s, but this is beyond the
scope of this CL, so feel free to ignore :).

[grt (UTC plus 2), 2012/09/19 19:43:15]

Ignored.  It's common to call this fn with a literal.  I don't like forcing the
construction of strings when not necessary.

+                                       prog_id_pred);
+  }
+
   // Note that we do not attempt to delete filetype associations since MSDN
   // says "Windows respects the Default value only if the ProgID found there is
   // a registered ProgID. If the ProgID is unregistered, it is ignored."
 
   *exit_code = installer::UNINSTALL_SUCCESSFUL;
   return true;
 }
 
 void RemoveChromeLegacyRegistryKeys(BrowserDistribution* dist,
                                     const string16& chrome_exe) {
@@ skipping 280 matching lines @@
                                  installer_state.target_path(), &ret);
 
     // If the user's Chrome is registered with a suffix: it is possible that old
     // unsuffixed registrations were left in HKCU (e.g. if this install was
     // previously installed with no suffix in HKCU (old suffix rules if the user
     // is not an admin (or declined UAC at first run)) and later had to be
     // suffixed when fully registered in HKLM (e.g. when later making Chrome
     // default through the UI)).
     // Remove remaining HKCU entries with no suffix if any.
     if (!suffix.empty()) {
       DeleteChromeRegistrationKeys(browser_dist, HKEY_CURRENT_USER, string16(),

[gab, 2012/09/19 16:11:16]

here.

                                    installer_state.target_path(), &ret);
 
       // For similar reasons it is possible in very few installs (from
       // 21.0.1180.0 and fixed shortly after) to be installed with the new-style
       // suffix, but have some old-style suffix registrations left behind.
       string16 old_style_suffix;
       if (ShellUtil::GetOldUserSpecificRegistrySuffix(&old_style_suffix) &&
           suffix != old_style_suffix) {
         DeleteChromeRegistrationKeys(browser_dist, HKEY_CURRENT_USER,
                                      old_style_suffix,
@@ skipping 26 matching lines @@
 
     ProcessDelegateExecuteWorkItems(installer_state, product);
 
     ProcessOnOsUpgradeWorkItems(installer_state, product);
 
 // TODO(gab): This is only disabled for M22 as the shortcut CL using Active
 // Setup will not make it in M22.
 #if 0
     UninstallActiveSetupEntries(installer_state, product);
 #endif
+
+    // Notify the shell that associations have changed since Chrome was likely
+    // unregistered.
+    SHChangeNotify(SHCNE_ASSOCCHANGED, SHCNF_IDLIST, NULL, NULL);
   }
 
   if (product.is_chrome_frame()) {
     ProcessChromeFrameWorkItems(original_state, installer_state, setup_path,
                                 product);
   }
 
   if (installer_state.is_multi_install())
     ProcessGoogleUpdateItems(original_state, installer_state, product);
 
@@ skipping 96 matching lines @@
 
   // Try and delete the preserved local state once the post-install
   // operations are complete.
   if (!backup_state_file.empty())
     file_util::Delete(backup_state_file, false);
 
   return ret;
 }
 
 }  // namespace installer