Run checked mode tests on the slow IE bot

utils/compiler/buildbot.py

 #!/usr/bin/python
 
 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Dart2js buildbot steps
 
 Runs tests for the  dart2js compiler.
 """
@@ skipping 324 matching lines @@
   """
   cmd = [sys.executable,
          './tools/clean_output_directory.py',
          '--mode=' + mode]
   print 'Clobbering %s' % (' '.join(cmd))
   return subprocess.call(cmd, env=NO_COLOR_ENV)
 
 def GetShouldClobber():
   return os.environ.get(BUILDER_CLOBBER) == "1"
 
+def GetHasHardCodedCheckedMode(build_info):
+  # TODO(ricow): We currently run checked mode tests on chrome on linux and
+  # on the slow (all) IE windows bots. This is a hack and we should use the
+  # normal sharding and checked splitting functionality when we get more
+  # vms for testing this.
+  if (build_info.system == 'linux' and build_info.runtime == 'chrome'):
+    return True
+  if (build_info.system == 'win7' and build_info.runtime == 'ie' and
+      build_info.test_set == 'all'):
+    return True
+  return False
+
 def main():
   if len(sys.argv) == 0:
     print 'Script pathname not known, giving up.'
     return 1
 
   build_info = GetBuildInfo()
 
   # Print out the buildinfo for easy debugging.
   build_info.PrintBuildInfo()
 
@@ skipping 19 matching lines @@
                   '--shard=%s' % build_info.shard_index]
 
   if build_info.checked: test_flags += ['--checked']
 
   if build_info.host_checked: test_flags += ['--host-checked']
 
   status = TestCompiler(build_info.runtime, build_info.mode,
                         build_info.system, test_flags,
                         build_info.is_buildbot, build_info.test_set)
 
-  # TODO(ricow): We currently have only one browser runtime that runs checked
-  # mode test where this is not reflected by the name, namely dart2js on chrome
-  # linux. We should eliminate this (by splitting this onto two builders -
-  # potentially on the same vm).
-  # When this is fixed we should simply pass build_info to TestCompiler.
-  if (status == 0 and build_info.system == 'linux' and
-      build_info.runtime == 'chrome'):
+  # See comment in GetHasHardCodedCheckedMode, this is a hack.
+  if (status == 0 and GetHasHardCodedCheckedMode(build_info)):
     status = TestCompiler(build_info.runtime, build_info.mode,
                           build_info.system,
                           test_flags  + ['--checked'],
                           build_info.is_buildbot,
                           build_info.test_set)
 
   if build_info.runtime != 'd8': CleanUpTemporaryFiles(build_info.system,
                                                        build_info.runtime)
   if status != 0: print '@@@STEP_FAILURE@@@'
   return status
 
 if __name__ == '__main__':
   sys.exit(main())