android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java - Issue 10946008: Componentize IgnoreNavigationResourceThrottle and add chrome and webview specific implementations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java

Issue 10946008: Componentize IgnoreNavigationResourceThrottle and add chrome and webview specific implementations. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fixed presubmit warning for jni_generator.py Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/NullContentsClient.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/util/TestWebServer.java » ('j') | android_webview/javatests/src/org/chromium/android_webview/test/util/TestWebServer.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java b/android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java

index 569c0a4abc1294a46bbba10bd9cfa1cc514c14ad..656fbe56e021945b67eee6fd6ebe11ab8bf8f3d6 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java

@@ -75,7 +75,7 @@ class TestAwContentsClient extends NullContentsClient {

mAddMessageToConsoleHelper.setLineNumber(consoleMessage.lineNumber());

mAddMessageToConsoleHelper.setSourceId(consoleMessage.sourceId());

mAddMessageToConsoleHelper.notifyCalled();

- return true;

+ return false;

}

public class AddMessageToConsoleHelper extends CallbackHelper {