android_webview/java/src/org/chromium/android_webview/AwContentsClient.java - Issue 10946008: Componentize IgnoreNavigationResourceThrottle and add chrome and webview specific implementations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

Issue 10946008: Componentize IgnoreNavigationResourceThrottle and add chrome and webview specific implementations. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fixed presubmit warning for jni_generator.py Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwContents.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/AwShouldIgnoreNavigationTest.java » ('j') | android_webview/javatests/src/org/chromium/android_webview/test/util/TestWebServer.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java b/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

index 15be5698b3c298b4ed6e54c92c0746850defe4d7..f64604027c7b16c37ff37dfa6e424eac2d3899d5 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

@@ -43,11 +43,6 @@ public abstract class AwContentsClient extends ContentViewClient {

}

@Override

- public boolean shouldOverrideUrlLoading(String url) {

- return AwContentsClient.this.shouldOverrideUrlLoading(url);

- }

- @Override

public void handleKeyboardEvent(KeyEvent event) {

AwContentsClient.this.onUnhandledKeyEvent(event);

}

@@ -147,7 +142,7 @@ public abstract class AwContentsClient extends ContentViewClient {

public abstract InterceptedRequestData shouldInterceptRequest(String url);

- public abstract boolean shouldOverrideUrlLoading(String url);

+ public abstract boolean shouldIgnoreNavigation(String url);

public abstract void onUnhandledKeyEvent(KeyEvent event);