Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10946004: Add a presubmit check for "? true : false". (Closed)

Created:
8 years, 3 months ago by Lei Zhang
Modified:
8 years, 3 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Visibility:
Public.

Description

Add a presubmit check for "? true : false". Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157461

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M PRESUBMIT.py View 1 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lei Zhang
memegen inspired!
8 years, 3 months ago (2012-09-18 04:05:49 UTC) #1
M-A Ruel
https://codereview.chromium.org/10946004/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/10946004/diff/1/PRESUBMIT.py#newcode384 PRESUBMIT.py:384: if not f.LocalPath().endswith(('.cc', '.h')): .mm, .m, .inl https://codereview.chromium.org/10946004/diff/1/PRESUBMIT.py#newcode388 PRESUBMIT.py:388: ...
8 years, 3 months ago (2012-09-18 10:20:39 UTC) #2
Lei Zhang
https://codereview.chromium.org/10946004/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/10946004/diff/1/PRESUBMIT.py#newcode384 PRESUBMIT.py:384: if not f.LocalPath().endswith(('.cc', '.h')): On 2012/09/18 10:20:40, Marc-Antoine Ruel ...
8 years, 3 months ago (2012-09-18 18:45:18 UTC) #3
M-A Ruel
8 years, 3 months ago (2012-09-18 19:49:33 UTC) #4 
lgtm

Powered by Google App Engine
This is Rietveld 408576698