[turbofan] Add single --turbo flag.

[turbofan] Add single --turbo flag.

This flag is intended as a staging flag for TurboFan. It serves as a
single flag that always enables a most recent configuration of TurboFan
for test suites and benchmarks, without needing to update test drivers.

R=titzer@chromium.org,machenbach@chromium.org

Committed: https://crrev.com/8924a9e1b7bb313e854f77a532f48a4ac213e04f
Cr-Commit-Position: refs/heads/master@{#27896}

[Michael Achenbach, 2015-04-16 11:37:21]

lgtm

https://codereview.chromium.org/1094573002/diff/1/src/flag-definitions.h
File src/flag-definitions.h (right):

https://codereview.chromium.org/1094573002/diff/1/src/flag-definitions.h#newc...
src/flag-definitions.h:384: DEFINE_VALUE_IMPLICATION(turbo, turbo_filter, "*")
I assume this can be overridden and e.g. has no meaning when
--turbo_filter=something_else is used on the command line?

[Michael Starzinger, 2015-04-16 12:10:23]

https://codereview.chromium.org/1094573002/diff/1/src/flag-definitions.h
File src/flag-definitions.h (right):

https://codereview.chromium.org/1094573002/diff/1/src/flag-definitions.h#newc...
src/flag-definitions.h:384: DEFINE_VALUE_IMPLICATION(turbo, turbo_filter, "*")
On 2015/04/16 11:37:21, Michael Achenbach wrote:
> I assume this can be overridden and e.g. has no meaning when
> --turbo_filter=something_else is used on the command line?

Unfortunately no. The implication always wins, this means --turbo always wins.
Hence "--turbo --turbo=filter=foo" will still set the filter to "*" and
--turbo-filter will be ignored, no matter in what order the flags appear on the
command line. Totally non-intuitive. :(

[titzer, 2015-04-16 12:13:42]

On 2015/04/16 12:10:23, Michael Starzinger wrote:
> https://codereview.chromium.org/1094573002/diff/1/src/flag-definitions.h
> File src/flag-definitions.h (right):
> 
>
https://codereview.chromium.org/1094573002/diff/1/src/flag-definitions.h#newc...
> src/flag-definitions.h:384: DEFINE_VALUE_IMPLICATION(turbo, turbo_filter, "*")
> On 2015/04/16 11:37:21, Michael Achenbach wrote:
> > I assume this can be overridden and e.g. has no meaning when
> > --turbo_filter=something_else is used on the command line?
> 
> Unfortunately no. The implication always wins, this means --turbo always wins.
> Hence "--turbo --turbo=filter=foo" will still set the filter to "*" and
> --turbo-filter will be ignored, no matter in what order the flags appear on
the
> command line. Totally non-intuitive. :(

That's gonna tough to use for debugging a failure, since --turbo-filter=* is
basically not settable in this mode...

[Michael Starzinger, 2015-04-16 13:56:50]

PTAL.

https://codereview.chromium.org/1094573002/diff/1/src/flag-definitions.h
File src/flag-definitions.h (right):

https://codereview.chromium.org/1094573002/diff/1/src/flag-definitions.h#newc...
src/flag-definitions.h:384: DEFINE_VALUE_IMPLICATION(turbo, turbo_filter, "*")
On 2015/04/16 12:10:22, Michael Starzinger wrote:
> On 2015/04/16 11:37:21, Michael Achenbach wrote:
> > I assume this can be overridden and e.g. has no meaning when
> > --turbo_filter=something_else is used on the command line?
> 
> Unfortunately no. The implication always wins, this means --turbo always wins.
> Hence "--turbo --turbo=filter=foo" will still set the filter to "*" and
> --turbo-filter will be ignored, no matter in what order the flags appear on
the
> command line. Totally non-intuitive. :(

Done. OK, this is the closest I could get it to what we want. Now --turbo-filter
(almost) always wins. Whenever the FLAG_turbo_filter is still set to the default
value after all flags have been parse, then --turbo will set --turbo-filter=* as
an implication. Is this good enough? WDYT?

[titzer, 2015-04-16 15:16:02]

lgtm

https://codereview.chromium.org/1094573002/diff/40001/src/v8.cc
File src/v8.cc (right):

https://codereview.chromium.org/1094573002/diff/40001/src/v8.cc#newcode80
src/v8.cc:80: if (FLAG_turbo && strcmp(FLAG_turbo_filter, "~") == 0) {
As discussed in person, '~~' for the new default.

[Michael Starzinger, 2015-04-16 15:20:16]

https://codereview.chromium.org/1094573002/diff/40001/src/v8.cc
File src/v8.cc (right):

https://codereview.chromium.org/1094573002/diff/40001/src/v8.cc#newcode80
src/v8.cc:80: if (FLAG_turbo && strcmp(FLAG_turbo_filter, "~") == 0) {
On 2015/04/16 15:16:01, titzer wrote:
> As discussed in person, '~~' for the new default.

Done.

[Michael Starzinger, 2015-04-16 16:27:30]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2015-04-16 16:27:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
machenbach@chromium.org, titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/1094573002/#ps80001
(title: "Fix size_t awesomeness!")

[commit-bot: I haz the power, 2015-04-16 16:27:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1094573002/80001

[commit-bot: I haz the power, 2015-04-16 16:28:50]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-04-16 16:29:06]

Patchset 5 (id:??) landed as
https://crrev.com/8924a9e1b7bb313e854f77a532f48a4ac213e04f
Cr-Commit-Position: refs/heads/master@{#27896}