Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 1094563002: Wrap map and set implementation in functions. (Closed)

Created:
5 years, 8 months ago by Yang
Modified:
5 years, 8 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Wrap map and set implementation in functions. R=jkummerow@chromium.org Committed: https://crrev.com/05bfdd866ab174f711932d20e336aaed66d58493 Cr-Commit-Position: refs/heads/master@{#27879}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -147 lines) Patch
M src/ast-value-factory.h View 1 chunk +1 line, -1 line 0 comments Download
M src/collection.js View 3 chunks +24 lines, -25 lines 0 comments Download
M src/collection-iterator.js View 3 chunks +54 lines, -61 lines 0 comments Download
M src/mirror-debugger.js View 3 chunks +5 lines, -5 lines 0 comments Download
M src/parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/promise.js View 1 chunk +0 lines, -1 line 0 comments Download
M src/templates.js View 2 chunks +8 lines, -7 lines 0 comments Download
M src/weak-collection.js View 3 chunks +37 lines, -46 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Yang
5 years, 8 months ago (2015-04-16 11:06:43 UTC) #1
Jakob Kummerow
lgtm
5 years, 8 months ago (2015-04-16 11:29:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1094563002/1
5 years, 8 months ago (2015-04-16 11:47:52 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 12:17:51 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 12:18:03 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/05bfdd866ab174f711932d20e336aaed66d58493
Cr-Commit-Position: refs/heads/master@{#27879}

Powered by Google App Engine
This is Rietveld 408576698