Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 1094513003: Follow up for issue 462861 to make canExecute true unconditionally. (Closed)

Created:
5 years, 8 months ago by Deepak
Modified:
5 years, 8 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

This is follow up for issue 462861. As we have separate handle for 'undo-command' for search box, so canExecute should be set to true unconditionally. BUG=477597 Committed: https://crrev.com/6e21167174bb16b1e79d1b0d547b8a0e9754946a Cr-Commit-Position: refs/heads/master@{#325422}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/bookmark_manager/js/main.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (2 generated)
Deepak
PTAL Thanks
5 years, 8 months ago (2015-04-16 08:54:03 UTC) #2
Bernhard Bauer
You mean r325258 (462861 is the bug, but the "r" prefix specifies the SVN revision ...
5 years, 8 months ago (2015-04-16 09:02:55 UTC) #3
Deepak
On 2015/04/16 09:02:55, Bernhard Bauer wrote: > You mean r325258 (462861 is the bug, but ...
5 years, 8 months ago (2015-04-16 09:04:08 UTC) #4
Bernhard Bauer
On 2015/04/16 09:04:08, Deepak wrote: > On 2015/04/16 09:02:55, Bernhard Bauer wrote: > > You ...
5 years, 8 months ago (2015-04-16 09:05:13 UTC) #5
Deepak
On 2015/04/16 09:05:13, Bernhard Bauer wrote: > On 2015/04/16 09:04:08, Deepak wrote: > > On ...
5 years, 8 months ago (2015-04-16 09:09:40 UTC) #6
Bernhard Bauer
lgtm
5 years, 8 months ago (2015-04-16 09:27:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1094513003/1
5 years, 8 months ago (2015-04-16 09:42:33 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 11:52:29 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 11:53:19 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e21167174bb16b1e79d1b0d547b8a0e9754946a
Cr-Commit-Position: refs/heads/master@{#325422}

Powered by Google App Engine
This is Rietveld 408576698