Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: tools/chrome_remote_control/chrome_remote_control/desktop_browser_finder.py

Issue 10945043: [chrome_remote_control] Use monkey patching for stubs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: PyLint Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/chrome_remote_control/chrome_remote_control/desktop_browser_finder.py
diff --git a/tools/chrome_remote_control/chrome_remote_control/desktop_browser_finder.py b/tools/chrome_remote_control/chrome_remote_control/desktop_browser_finder.py
index 8f0f9bd62ea5ae7584af903ee40ab0bfe817963d..3c19415abd3229f1bbe91d5a80112e5e7bcdded1 100644
--- a/tools/chrome_remote_control/chrome_remote_control/desktop_browser_finder.py
+++ b/tools/chrome_remote_control/chrome_remote_control/desktop_browser_finder.py
@@ -4,9 +4,9 @@
"""Finds desktop browsers that can be controlled by chrome_remote_control."""
import logging
-import os as real_os
-import sys as real_sys
-import subprocess as real_subprocess
+import os
+import subprocess
+import sys
from chrome_remote_control import browser
from chrome_remote_control import desktop_browser_backend
@@ -37,10 +37,7 @@ class PossibleDesktopBrowser(possible_browser.PossibleBrowser):
self._options, self._local_executable, self._is_content_shell)
return browser.Browser(backend)
-def FindAllAvailableBrowsers(options,
- os = real_os,
- sys = real_sys,
- subprocess = real_subprocess):
+def FindAllAvailableBrowsers(options):
"""Finds all the desktop browsers available on this machine."""
browsers = []
@@ -107,7 +104,7 @@ def FindAllAvailableBrowsers(options,
# Look for a google-chrome instance.
found = False
try:
- with open(real_os.devnull, 'w') as devnull:
+ with open(os.devnull, 'w') as devnull:
found = subprocess.call(['google-chrome', '--version'],
stdout=devnull, stderr=devnull) == 0
except OSError:

Powered by Google App Engine
This is Rietveld 408576698