[chrome_remote_control] Use monkey patching for stubs.

[chrome_remote_control] Use monkey patching for stubs.

system_stubs.Override class ensures that patches are temporary.


BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=159116

[nduca, 2012-09-20 04:18:30]

http://codereview.chromium.org/10945043/diff/1/tools/chrome_remote_control/ch...
File
tools/chrome_remote_control/chrome_remote_control/desktop_browser_finder_unittest.py
(right):

http://codereview.chromium.org/10945043/diff/1/tools/chrome_remote_control/ch...
tools/chrome_remote_control/chrome_remote_control/desktop_browser_finder_unittest.py:22:
self._subprocess_stub = SubprocessModuleStub()
Where do you tear down?

http://codereview.chromium.org/10945043/diff/1/tools/chrome_remote_control/ch...
tools/chrome_remote_control/chrome_remote_control/desktop_browser_finder_unittest.py:30:
os=self._os_stub,
how about making override just create all the right things and override them in
setUp/tearDown, and thenwe do all the customizations of the stubs by mutating
the monkey patched forms? 

And how is Override getting into the namespace?

http://codereview.chromium.org/10945043/diff/1/tools/chrome_remote_control/ch...
File tools/chrome_remote_control/chrome_remote_control/system_stub.py (right):

http://codereview.chromium.org/10945043/diff/1/tools/chrome_remote_control/ch...
tools/chrome_remote_control/chrome_remote_control/system_stub.py:27: 
should __del__ throw an exception if they didn't exit?

[dtu, 2012-09-25 02:01:50]

https://chromiumcodereview.appspot.com/10945043/diff/1/tools/chrome_remote_co...
File
tools/chrome_remote_control/chrome_remote_control/desktop_browser_finder_unittest.py
(right):

https://chromiumcodereview.appspot.com/10945043/diff/1/tools/chrome_remote_co...
tools/chrome_remote_control/chrome_remote_control/desktop_browser_finder_unittest.py:22:
self._subprocess_stub = SubprocessModuleStub()
On 2012/09/20 04:18:30, nduca wrote:
> Where do you tear down?

Done.

https://chromiumcodereview.appspot.com/10945043/diff/1/tools/chrome_remote_co...
tools/chrome_remote_control/chrome_remote_control/desktop_browser_finder_unittest.py:30:
os=self._os_stub,
On 2012/09/20 04:18:30, nduca wrote:
> how about making override just create all the right things and override them
in
> setUp/tearDown, and thenwe do all the customizations of the stubs by mutating
> the monkey patched forms? 
> 
> And how is Override getting into the namespace?

Done. Override is from system_stub.

[nduca, 2012-09-25 02:12:57]

A few more nits. LGTM assuming you can get clean solutions to the comments
below.

https://chromiumcodereview.appspot.com/10945043/diff/5001/tools/chrome_remote...
File tools/chrome_remote_control/chrome_remote_control/system_stub.py (right):

https://chromiumcodereview.appspot.com/10945043/diff/5001/tools/chrome_remote...
tools/chrome_remote_control/chrome_remote_control/system_stub.py:26: def
__del__(self):
this is fragile. GC is unpredictable. Del should assert that it was restored.

https://chromiumcodereview.appspot.com/10945043/diff/5001/tools/chrome_remote...
tools/chrome_remote_control/chrome_remote_control/system_stub.py:123: stubs =
{'adb_commands': AdbCommandsModuleStub,
do we need this? You should be able to directly call these within the __init__
function... they wont get bound until the init function, iirw?

[commit-bot: I haz the power, 2012-09-25 23:23:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dtu@chromium.org/10945043/9001

[commit-bot: I haz the power, 2012-09-26 00:11:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dtu@chromium.org/10945043/9001

[commit-bot: I haz the power, 2012-09-26 00:42:25]

Step "update" is always a major failure.
Look at the try server FAQ for more details.