Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 10945026: Fix crash in Extension::GetBrowserImages() (Closed)

Created:
8 years, 3 months ago by tbarzic
Modified:
8 years, 3 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Fix crash in Extension::GetBrowserImages() BUG=150763 TEST=successfully installed browser action extension without default icon defined in manifest Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157560

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/common/extensions/extension.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tbarzic
8 years, 3 months ago (2012-09-19 15:01:54 UTC) #1
Aaron Boodman
8 years, 3 months ago (2012-09-19 17:02:13 UTC) #2
lgtm, thanks!

Powered by Google App Engine
This is Rietveld 408576698