Remove check for stack overflow on entry to an inlined function.

runtime/vm/flow_graph_builder.cc

Index: runtime/vm/flow_graph_builder.cc
diff --git a/runtime/vm/flow_graph_builder.cc b/runtime/vm/flow_graph_builder.cc
index a736ab9ca89700e3b68bb64d83035a14df68a182..ef64740dcf3bf56384fdeaa01ff7e68b5042730a 100644
--- a/runtime/vm/flow_graph_builder.cc
+++ b/runtime/vm/flow_graph_builder.cc
@@ -2605,7 +2605,8 @@ FlowGraph* FlowGraphBuilder::BuildGraph(InliningContext context) {
   }
   // TODO(kmillikin): We can eliminate stack checks in some cases (e.g., the
   // stack check on entry for leaf routines).
-  for_effect.Do(new CheckStackOverflowInstr(function.token_pos()));
+  Definition* check = new CheckStackOverflowInstr(function.token_pos());

[Kevin Millikin (Google), 2012/09/19 12:01:17]

Please add a comment that we allocate the instruction in all cases to assign a
deopt id to it, but discard the instruction if inlining.

+  if (!InInliningContext()) for_effect.Do(check);
   parsed_function().node_sequence()->Visit(&for_effect);
   AppendFragment(normal_entry, for_effect);
   // Check that the graph is properly terminated.