Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 1094453004: Revert of Remove WebViewImpl::setIsAcceleratedCompositingActive (Closed)

Created:
5 years, 8 months ago by enne (OOO)
Modified:
5 years, 8 months ago
Reviewers:
pdr.
CC:
blink-reviews, danakj, jamesr
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Remove WebViewImpl::setIsAcceleratedCompositingActive (patchset #5 id:80001 of https://codereview.chromium.org/1078473002/) Reason for revert: Causes blank pages on load sometimes Original issue's description: > Remove WebViewImpl::setIsAcceleratedCompositingActive > > This function no longer makes sense now that WebViewImpl is either > always or never composited. The setup that is done when a new > root layer is set is now done whenever those settings are changed, > as the WebLayerTreeView is always there to store those values. > > There's nothing pressing here to change this; it's just previous > cruft that never got removed when force compositing mode got turned > on. The new code seems a lot cleaner. > > BUG=474818 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193897 TBR=pdr@chromium.org BUG=474818, 479270, 478578, 478686 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194244

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -30 lines) Patch
M Source/web/WebViewImpl.h View 2 chunks +6 lines, -0 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 15 chunks +85 lines, -30 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
enne (OOO)
Created Revert of Remove WebViewImpl::setIsAcceleratedCompositingActive
5 years, 8 months ago (2015-04-22 18:27:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1094453004/1
5 years, 8 months ago (2015-04-22 18:30:17 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 23:07:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194244

Powered by Google App Engine
This is Rietveld 408576698