base: Rename DiscardableMemory::Memory() to ::data().

base: Rename DiscardableMemory::Memory() to ::data().

This make the API more consistent with RefCountedMemory and
other discardable memory interfaces such as SkDiscardableMemory.

Also improves readability by replacing memory->Memory() calls
with memory->data() calls.

A handy method is also added to simplify calling data() with a
reinterpret_cast. This is also consistent with RefCountedMemory.

BUG=

Committed: https://crrev.com/2cc373d6b2ad69b148aac9beed6874b9c8f606a5
Cr-Commit-Position: refs/heads/master@{#325509}

[reveman, 2015-04-16 04:23:09]

reveman@chromium.org changed reviewers:
+ avi@chromium.org

[Avi (use Gerrit), 2015-04-16 14:43:25]

LGTM, though I was looking forward to seeing some uses of the cast.

[reveman, 2015-04-16 15:47:19]

On 2015/04/16 at 14:43:25, avi wrote:
> LGTM, though I was looking forward to seeing some uses of the cast.

Added the data_as() method as it made some discardable memory example code I'm
working much cleaner. The plan is to land these examples as a set of chrome
integration tests. Let me know if you prefer delay the inclusion of this method
until it's actually used.

[reveman, 2015-04-16 15:50:13]

reveman@chromium.org changed reviewers:
+ sky@chromium.org, thakis@chromium.org

[reveman, 2015-04-16 15:50:13]

+thakis for base/ and skia/
+sky for mojo/services/html_viewer/

[sky, 2015-04-16 16:07:02]

LGTM

[Nico, 2015-04-16 16:41:48]

lgtm

[Avi (use Gerrit), 2015-04-16 18:52:53]

On 2015/04/16 15:47:19, reveman wrote:
> On 2015/04/16 at 14:43:25, avi wrote:
> > LGTM, though I was looking forward to seeing some uses of the cast.
> 
> Added the data_as() method as it made some discardable memory example code I'm
> working much cleaner. The plan is to land these examples as a set of chrome
> integration tests. Let me know if you prefer delay the inclusion of this
method
> until it's actually used.

No, landing it now is fine with me.

[reveman, 2015-04-16 19:44:51]

The CQ bit was checked by reveman@chromium.org

[commit-bot: I haz the power, 2015-04-16 19:45:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1094433002/60001

[commit-bot: I haz the power, 2015-04-16 20:52:29]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-04-16 20:53:38]

Patchset 4 (id:??) landed as
https://crrev.com/2cc373d6b2ad69b148aac9beed6874b9c8f606a5
Cr-Commit-Position: refs/heads/master@{#325509}