Issue 109443004: Separate out pkg-config execution in the GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 109443004: Separate out pkg-config execution in the GN build. (Closed)

Created:
7 years ago by brettw

Modified:
7 years ago

Reviewers:
piman

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Separate out pkg-config execution in the GN build. This makes a template to invoke the pkg-config script so that we can change how it's invoked in one place rather than in every call site. BUG= R=piman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241068

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -52 lines)			Patch
M	build/config/linux/BUILD.gn	View		2 chunks	+12 lines, -37 lines	0 comments	Download
A	build/config/linux/pkg_config.gni	View	1 2	1 chunk	+30 lines, -0 lines	0 comments	Download
M	tools/gn/secondary/crypto/ssl/BUILD.gn	View		2 chunks	+3 lines, -7 lines	0 comments	Download
M	tools/gn/secondary/third_party/nss/BUILD.gn	View		1 chunk	+4 lines, -8 lines	0 comments	Download

Total messages: 3 (0 generated)

Message was sent while issue was closed.

Committed patchset #3 manually as r241068 (presubmit successful).