Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: pkg/unittest/interfaces.dart

Issue 10944039: Add explicit 'abstract' to abstract methods. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/unittest/interfaces.dart
===================================================================
--- pkg/unittest/interfaces.dart (revision 12573)
+++ pkg/unittest/interfaces.dart (working copy)
@@ -25,19 +25,19 @@
*/
abstract class Description {
/** Change the value of the description. */
- Description replace(String text);
+ abstract Description replace(String text);
/** This is used to add arbitrary text to the description. */
- Description add(String text);
+ abstract Description add(String text);
/** This is used to add a meaningful description of a value. */
- Description addDescriptionOf(value);
+ abstract Description addDescriptionOf(value);
/**
* This is used to add a description of an [Iterable] [list],
* with appropriate [start] and [end] markers and inter-element [separator].
*/
- Description addAll(String start, String separator, String end,
+ abstract Description addAll(String start, String separator, String end,
Iterable list);
}
@@ -56,10 +56,10 @@
* and may be used to add details about the mismatch that are too
* costly to determine in [describeMismatch].
*/
- bool matches(item, MatchState matchState);
+ abstract bool matches(item, MatchState matchState);
/** This builds a textual description of the matcher. */
- Description describe(Description description);
+ abstract Description describe(Description description);
/**
* This builds a textual description of a specific mismatch. [item]
@@ -71,7 +71,7 @@
* information that is not typically included but can be of help in
* diagnosing failures, such as stack traces.
*/
- Description describeMismatch(item, Description mismatchDescription,
+ abstract Description describeMismatch(item, Description mismatchDescription,
MatchState matchState, bool verbose);
}
@@ -83,7 +83,7 @@
*/
abstract class FailureHandler {
/** This handles failures given a textual decription */
- void fail(String reason);
+ abstract void fail(String reason);
/**
* This handles failures given the actual [value], the [matcher]
@@ -93,7 +93,7 @@
* these to create a detailed error message (typically by calling
* an [ErrorFormatter]) and then call [fail] with this message.
*/
- void failMatch(actual, Matcher matcher, String reason,
+ abstract void failMatch(actual, Matcher matcher, String reason,
MatchState matchState, bool verbose);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698