Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Side by Side Diff: chrome/browser/ui/tab_contents/tab_contents.cc

Issue 10944016: Switch SearchTabHelper to use WebContentsUserData. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/tab_contents/tab_contents.h" 5 #include "chrome/browser/ui/tab_contents/tab_contents.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/lazy_instance.h" 8 #include "base/lazy_instance.h"
9 #include "chrome/browser/autofill/autocomplete_history_manager.h" 9 #include "chrome/browser/autofill/autocomplete_history_manager.h"
10 #include "chrome/browser/autofill/autofill_external_delegate.h" 10 #include "chrome/browser/autofill/autofill_external_delegate.h"
(...skipping 26 matching lines...) Expand all
37 #include "chrome/browser/ui/blocked_content/blocked_content_tab_helper.h" 37 #include "chrome/browser/ui/blocked_content/blocked_content_tab_helper.h"
38 #include "chrome/browser/ui/bookmarks/bookmark_tab_helper.h" 38 #include "chrome/browser/ui/bookmarks/bookmark_tab_helper.h"
39 #include "chrome/browser/ui/constrained_window_tab_helper.h" 39 #include "chrome/browser/ui/constrained_window_tab_helper.h"
40 #include "chrome/browser/ui/find_bar/find_tab_helper.h" 40 #include "chrome/browser/ui/find_bar/find_tab_helper.h"
41 #include "chrome/browser/ui/hung_plugin_tab_helper.h" 41 #include "chrome/browser/ui/hung_plugin_tab_helper.h"
42 #include "chrome/browser/ui/intents/web_intent_picker_controller.h" 42 #include "chrome/browser/ui/intents/web_intent_picker_controller.h"
43 #include "chrome/browser/ui/metro_pin_tab_helper.h" 43 #include "chrome/browser/ui/metro_pin_tab_helper.h"
44 #include "chrome/browser/ui/pdf/pdf_tab_helper.h" 44 #include "chrome/browser/ui/pdf/pdf_tab_helper.h"
45 #include "chrome/browser/ui/prefs/prefs_tab_helper.h" 45 #include "chrome/browser/ui/prefs/prefs_tab_helper.h"
46 #include "chrome/browser/ui/sad_tab_helper.h" 46 #include "chrome/browser/ui/sad_tab_helper.h"
47 #include "chrome/browser/ui/search/search.h"
48 #include "chrome/browser/ui/search/search_tab_helper.h" 47 #include "chrome/browser/ui/search/search_tab_helper.h"
49 #include "chrome/browser/ui/search_engines/search_engine_tab_helper.h" 48 #include "chrome/browser/ui/search_engines/search_engine_tab_helper.h"
50 #include "chrome/browser/ui/snapshot_tab_helper.h" 49 #include "chrome/browser/ui/snapshot_tab_helper.h"
51 #include "chrome/browser/ui/sync/one_click_signin_helper.h" 50 #include "chrome/browser/ui/sync/one_click_signin_helper.h"
52 #include "chrome/browser/ui/sync/tab_contents_synced_tab_delegate.h" 51 #include "chrome/browser/ui/sync/tab_contents_synced_tab_delegate.h"
53 #include "chrome/browser/ui/tab_contents/core_tab_helper.h" 52 #include "chrome/browser/ui/tab_contents/core_tab_helper.h"
54 #include "chrome/browser/ui/zoom/zoom_controller.h" 53 #include "chrome/browser/ui/zoom/zoom_controller.h"
55 #include "chrome/browser/view_type_utils.h" 54 #include "chrome/browser/view_type_utils.h"
56 #include "chrome/common/chrome_notification_types.h" 55 #include "chrome/common/chrome_notification_types.h"
57 #include "chrome/common/chrome_switches.h" 56 #include "chrome/common/chrome_switches.h"
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 history_tab_helper_.reset(new HistoryTabHelper(contents)); 137 history_tab_helper_.reset(new HistoryTabHelper(contents));
139 hung_plugin_tab_helper_.reset(new HungPluginTabHelper(contents)); 138 hung_plugin_tab_helper_.reset(new HungPluginTabHelper(contents));
140 infobar_tab_helper_.reset(new InfoBarTabHelper(contents)); 139 infobar_tab_helper_.reset(new InfoBarTabHelper(contents));
141 MetroPinTabHelper::CreateForWebContents(contents); 140 MetroPinTabHelper::CreateForWebContents(contents);
142 password_manager_delegate_.reset(new PasswordManagerDelegateImpl(this)); 141 password_manager_delegate_.reset(new PasswordManagerDelegateImpl(this));
143 password_manager_.reset( 142 password_manager_.reset(
144 new PasswordManager(contents, password_manager_delegate_.get())); 143 new PasswordManager(contents, password_manager_delegate_.get()));
145 prefs_tab_helper_.reset(new PrefsTabHelper(contents)); 144 prefs_tab_helper_.reset(new PrefsTabHelper(contents));
146 prerender_tab_helper_.reset(new prerender::PrerenderTabHelper(this)); 145 prerender_tab_helper_.reset(new prerender::PrerenderTabHelper(this));
147 search_engine_tab_helper_.reset(new SearchEngineTabHelper(contents)); 146 search_engine_tab_helper_.reset(new SearchEngineTabHelper(contents));
148 bool is_search_enabled = 147 chrome::search::SearchTabHelper::CreateForWebContents(contents);
149 chrome::search::IsInstantExtendedAPIEnabled(profile());
150 search_tab_helper_.reset(
151 new chrome::search::SearchTabHelper(this, is_search_enabled));
152 SnapshotTabHelper::CreateForWebContents(contents); 148 SnapshotTabHelper::CreateForWebContents(contents);
153 SSLTabHelper::CreateForWebContents(contents); 149 SSLTabHelper::CreateForWebContents(contents);
154 synced_tab_delegate_.reset(new TabContentsSyncedTabDelegate(this)); 150 synced_tab_delegate_.reset(new TabContentsSyncedTabDelegate(this));
155 translate_tab_helper_.reset(new TranslateTabHelper(contents)); 151 translate_tab_helper_.reset(new TranslateTabHelper(contents));
156 zoom_controller_.reset(new ZoomController(this)); 152 zoom_controller_.reset(new ZoomController(this));
157 153
158 #if defined(ENABLE_AUTOMATION) 154 #if defined(ENABLE_AUTOMATION)
159 automation_tab_helper_.reset(new AutomationTabHelper(contents)); 155 automation_tab_helper_.reset(new AutomationTabHelper(contents));
160 #endif 156 #endif
161 157
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
247 243
248 //////////////////////////////////////////////////////////////////////////////// 244 ////////////////////////////////////////////////////////////////////////////////
249 // WebContentsObserver overrides 245 // WebContentsObserver overrides
250 246
251 void TabContents::WebContentsDestroyed(WebContents* tab) { 247 void TabContents::WebContentsDestroyed(WebContents* tab) {
252 // Destruction of the WebContents should only be done by us from our 248 // Destruction of the WebContents should only be done by us from our
253 // destructor. Otherwise it's very likely we (or one of the helpers we own) 249 // destructor. Otherwise it's very likely we (or one of the helpers we own)
254 // will attempt to access the WebContents and we'll crash. 250 // will attempt to access the WebContents and we'll crash.
255 DCHECK(in_destructor_); 251 DCHECK(in_destructor_);
256 } 252 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698