Fix to enable the cached credentials login test

chrome/browser/automation/testing_automation_provider_chromeos.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/automation/testing_automation_provider.h"
 
 #include "ash/shell.h"
 #include "ash/shell_delegate.h"
 #include "ash/system/tray/system_tray_delegate.h"
 #include "base/command_line.h"
@@ skipping 338 matching lines @@
 // flags. If you used EnableChromeTesting, you will have to call it again.
 void TestingAutomationProvider::LoginAsGuest(DictionaryValue* args,
                                              IPC::Message* reply_message) {
   ExistingUserController* controller =
       ExistingUserController::current_controller();
   // Return immediately, since we're going to die before the login is finished.
   AutomationJSONReply(this, reply_message).SendSuccess(NULL);
   controller->LoginAsGuest();
 }
 
+void TestingAutomationProvider::LoginWithCachedCredentials(
+    DictionaryValue* args,
+    IPC::Message* reply_message) {
+  AutomationJSONReply reply(this, reply_message);
+
+  std::string username, password;
+  if (!args->GetString("username", &username) ||
+      !args->GetString("password", &password)) {
+    reply.SendError("Invalid or missing args.");
+    return;
+  }
+
+  chromeos::ExistingUserController* controller =
+      chromeos::ExistingUserController::current_controller();
+  if (!controller) {
+    reply.SendError("Unable to access ExistingUserController");
+    return;
+  }
+
+  // WebUI login.
+  chromeos::WebUILoginDisplay* webui_login_display =
+      static_cast<chromeos::WebUILoginDisplay*>(controller->login_display());
+
+  webui_login_display->Login(username, password);

[craigdh, 2012/09/18 18:16:35]

This looks identical to SubmitLoginForm except for this line. I suggest making
them one command that takes a use_cached_credentials boolean option to choose
the login behavior. This would also allow removal of the duplicated (non-trival)
Python code.

[beeps, 2012/09/19 16:29:02]

Done.

+  reply.SendSuccess(NULL);
+}
+
 void TestingAutomationProvider::SubmitLoginForm(DictionaryValue* args,
                                                 IPC::Message* reply_message) {
   AutomationJSONReply reply(this, reply_message);
 
   std::string username, password;
   if (!args->GetString("username", &username) ||
       !args->GetString("password", &password)) {
     reply.SendError("Invalid or missing args.");
     return;
   }
@@ skipping 1143 matching lines @@
   chromeos::DBusThreadManager::Get()->GetPowerManagerClient()->
       AddObserver(power_manager_observer_);
 }
 
 void TestingAutomationProvider::RemoveChromeosObservers() {
   chromeos::DBusThreadManager::Get()->GetPowerManagerClient()->
       RemoveObserver(power_manager_observer_);
   delete power_manager_observer_;
   power_manager_observer_ = NULL;
 }