Make original_response_headers parameter of NetworkDelegate::OnHeadersReceived const

net/base/network_delegate.h

Index: net/base/network_delegate.h
diff --git a/net/base/network_delegate.h b/net/base/network_delegate.h
index ed571972fe6acc0d5376c847d3009a7d42e52f3b..907d0b9b739a9711fad95ae474adcde8a904ab1d 100644
--- a/net/base/network_delegate.h
+++ b/net/base/network_delegate.h
@@ -73,7 +73,7 @@ class NetworkDelegate : public base::NonThreadSafe {
   int NotifyHeadersReceived(
       URLRequest* request,
       const CompletionCallback& callback,
-      HttpResponseHeaders* original_response_headers,
+      const HttpResponseHeaders* original_response_headers,

[jochen (gone - plz use gerrit), 2012/10/20 02:04:13]

why are you making this a const ptr instead of a const ref?

[battre, 2012/10/20 09:49:56]

like for URLRequest, you are allowed to hold on to the pointer if you are
careful about the life-time management. Pass by reference indicates in my mind
that you must not store a pointer to the element because it is only guaranteed
to be valid during the life-time of the call.

       scoped_refptr<HttpResponseHeaders>* override_response_headers);
   void NotifyBeforeRedirect(URLRequest* request,
                             const GURL& new_location);
@@ -146,7 +146,7 @@ class NetworkDelegate : public base::NonThreadSafe {
   virtual int OnHeadersReceived(
       URLRequest* request,
       const CompletionCallback& callback,
-      HttpResponseHeaders* original_response_headers,
+      const HttpResponseHeaders* original_response_headers,
       scoped_refptr<HttpResponseHeaders>* override_response_headers) = 0;
 
   // Called right after a redirect response code was received.