Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(888)

Issue 10944004: views/examples: Export ShowExamplesWindow() function. (Closed)

Created:
8 years, 3 months ago by tfarina
Modified:
8 years, 3 months ago
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

views/examples: Export ShowExamplesWindow() function. We need to export this function because views_examples_lib is now a component target, i.e, it can be built either as static_library or shared_library, and in shared_library this function should be exported. BUG=141187 TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157474

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ui/views/examples/examples_window.h View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
Now win trybot is happy ;)
8 years, 3 months ago (2012-09-18 02:35:55 UTC) #1
Ben Goodger (Google)
8 years, 3 months ago (2012-09-18 22:34:16 UTC) #2
lgtm


On Mon, Sep 17, 2012 at 7:35 PM, <tfarina@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Message:
> Now win trybot is happy ;)
>
> Description:
> views/examples: Export ShowExamplesWindow() function.
>
> We need to export this function because views_examples_lib is now a
> component
> target, i.e, it can be built either as static_library or shared_library,
> and
> in shared_library this function should be exported.
>
> BUG=141187
> TBR=ben@chromium.org
>
>
> Please review this at
http://codereview.chromium.**org/10944004/<http://codereview.chromium.org/109...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M ui/views/examples/examples_**window.h
>
>
> Index: ui/views/examples/examples_**window.h
> diff --git a/ui/views/examples/examples_**window.h
> b/ui/views/examples/examples_**window.h
> index a3fc4e5af7cdf43d6b6aa18559811c**57d1ebda17..**
> 94139db4d096ea31a992434db6f4f1**a977af30a8 100644
> --- a/ui/views/examples/examples_**window.h
> +++ b/ui/views/examples/examples_**window.h
> @@ -5,6 +5,8 @@
>  #ifndef UI_VIEWS_EXAMPLES_EXAMPLES_**WINDOW_H_
>  #define UI_VIEWS_EXAMPLES_EXAMPLES_**WINDOW_H_
>
> +#include "ui/views/examples/views_**examples_export.h"
> +
>  namespace views {
>  namespace examples {
>
> @@ -14,7 +16,7 @@ enum Operation {
>  };
>
>  // Shows a window with the views examples in it.
> -void ShowExamplesWindow(Operation operation);
> +VIEWS_EXAMPLES_EXPORT void ShowExamplesWindow(Operation operation);
>
>  }  // namespace examples
>  }  // namespace views
>
>
>

Powered by Google App Engine
This is Rietveld 408576698