Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 10944: Restructure analysis (Closed)

Created:
12 years, 1 month ago by Christian Plesner Hansen
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

- Split analysis into two separate visitors, one for filling out dispatch tables and one for propagating information about nodes. - Integrated dispatch table layout in dot graphs. - Renamed choice/child nodes of disjunctions to alternatives, for uniformity.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+318 lines, -182 lines) Patch
M src/ast.h View 1 chunk +4 lines, -3 lines 0 comments Download
M src/ast.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/jsregexp.h View 8 chunks +88 lines, -19 lines 0 comments Download
M src/jsregexp.cc View 14 chunks +203 lines, -154 lines 0 comments Download
M src/jsregexp-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/string-stream.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/string-stream.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M test/cctest/test-regexp.cc View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Christian Plesner Hansen
12 years, 1 month ago (2008-11-14 11:00:33 UTC) #1
Erik Corry
12 years, 1 month ago (2008-11-14 11:33:03 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698