Issue 10944: Restructure analysis

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10944: Restructure analysis (Closed)

Created:
12 years, 1 month ago by Christian Plesner Hansen

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Visibility:
Public.

Description

- Split analysis into two separate visitors, one for filling out dispatch tables and one for propagating information about nodes. - Integrated dispatch table layout in dot graphs. - Renamed choice/child nodes of disjunctions to alternatives, for uniformity.

Patch Set 1 #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+318 lines, -182 lines)			Patch
M	src/ast.h	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	src/ast.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/jsregexp.h	View	8 chunks	+88 lines, -19 lines	0 comments	Download
M	src/jsregexp.cc	View	14 chunks	+203 lines, -154 lines	0 comments	Download
M	src/jsregexp-inl.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/string-stream.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/string-stream.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	test/cctest/test-regexp.cc	View	2 chunks	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages