Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1094393003: Revert of update chrome to handle temporary WEB_FRAME_USES_V8_LOCAL condition (Closed)

Created:
5 years, 8 months ago by dcarney
Modified:
5 years, 8 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, je_julie(Not used), plundblad+watch_chromium.org, extensions-reviews_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, piman+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, chromium-apps-reviews_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of update chrome to handle temporary WEB_FRAME_USES_V8_LOCAL condition (patchset #1 id:1 of https://codereview.chromium.org/1095463003/) Reason for revert: this cl was just a temporary bridge and is no longer needed Original issue's description: > update chrome to handle temporary WEB_FRAME_USES_V8_LOCAL condition > > note: this cl will be reverted once v8::Local is aliased to v8::Handle > > TBR=kalman@chromium.org > BUG= > > Committed: https://crrev.com/dd8fc1ebd8763c1a7a93dcf54417eb5aba4599cb > Cr-Commit-Position: refs/heads/master@{#325417} TBR=jochen@chromium.org,kalman@chromium.org BUG= Committed: https://crrev.com/581222c25bb9b1c435be50bb9d434bef564f02c5 Cr-Commit-Position: refs/heads/master@{#326477}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -43 lines) Patch
M content/renderer/gpu/gpu_benchmarking_extension.cc View 1 chunk +1 line, -4 lines 0 comments Download
M content/renderer/pepper/ppb_var_deprecated_impl.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/renderer/web_ui_runner.cc View 1 chunk +1 line, -7 lines 0 comments Download
M content/shell/renderer/test_runner/accessibility_controller.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/shell/renderer/test_runner/web_ax_object_proxy.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/renderer/script_context.cc View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcarney
Created Revert of update chrome to handle temporary WEB_FRAME_USES_V8_LOCAL condition
5 years, 8 months ago (2015-04-23 08:42:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1094393003/1
5 years, 8 months ago (2015-04-23 08:42:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1094393003/1
5 years, 8 months ago (2015-04-23 08:43:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-23 08:44:11 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 08:45:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/581222c25bb9b1c435be50bb9d434bef564f02c5
Cr-Commit-Position: refs/heads/master@{#326477}

Powered by Google App Engine
This is Rietveld 408576698