Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8772)

Unified Diff: chrome/test/data/extensions/api_test/window_open/panel/test.js

Issue 1094383005: Modified two extension tests to not be dependent on low-latency DOM timers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/extensions/api_test/bookmarks/manifest.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/extensions/api_test/window_open/panel/test.js
diff --git a/chrome/test/data/extensions/api_test/window_open/panel/test.js b/chrome/test/data/extensions/api_test/window_open/panel/test.js
index f55054db50f90d8a7ccaa018c2cbe3b9babf1822..1dc10537540e9df0ac4b29db1fd3a8b6f3a10094 100644
--- a/chrome/test/data/extensions/api_test/window_open/panel/test.js
+++ b/chrome/test/data/extensions/api_test/window_open/panel/test.js
@@ -2,15 +2,10 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-var panelWindowId = 0;
-
// This function is called by the panel during the test run.
function panelCallback() {
// We have now added a panel so the total counts is 2 (browser + panel).
chrome.test.assertEq(2, chrome.extension.getViews().length);
- // Verify that we're able to get the view of the panel by its window id.
- chrome.test.assertEq(1,
- chrome.extension.getViews({"windowId": panelWindowId}).length);
chrome.test.notifyPass();
}
@@ -27,7 +22,10 @@ chrome.test.runTests([
function(win) {
chrome.test.assertEq('panel', win.type);
chrome.test.assertEq(true, win.alwaysOnTop);
- panelWindowId = win.id;
+ // Verify that we're able to get the view of the panel by its
+ // window id.
+ chrome.test.assertEq(1,
+ chrome.extension.getViews({"windowId": win.id}).length);
not at google - send to devlin 2015/04/24 22:18:10 This test still has a small problem, where if pane
// The panel will call back to us through panelCallback (above).
});
}
« no previous file with comments | « chrome/test/data/extensions/api_test/bookmarks/manifest.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698