Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2164)

Issue 1094383004: Always optimize for adding properties to native objects. (Closed)

Created:
5 years, 8 months ago by Yang
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Always optimize for adding properties to native objects. R=jkummerow@chromium.org Committed: https://crrev.com/c715098e85b93def76c0b3f54290c811dea04f01 Cr-Commit-Position: refs/heads/master@{#28003}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M src/v8natives.js View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Yang
5 years, 8 months ago (2015-04-22 11:11:57 UTC) #1
Jakob Kummerow
lgtm
5 years, 8 months ago (2015-04-22 11:17:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1094383004/1
5 years, 8 months ago (2015-04-22 11:31:32 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-22 12:11:23 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c715098e85b93def76c0b3f54290c811dea04f01 Cr-Commit-Position: refs/heads/master@{#28003}
5 years, 8 months ago (2015-04-22 13:19:32 UTC) #6
Yang
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1098223004/ by yangguo@chromium.org. ...
5 years, 8 months ago (2015-04-22 13:20:52 UTC) #7
Toon Verwaest
What objects is this change for?
5 years, 8 months ago (2015-04-22 17:03:25 UTC) #9
Yang
5 years, 8 months ago (2015-04-23 13:59:35 UTC) #10
Message was sent while issue was closed.
On 2015/04/22 17:03:25, Toon Verwaest wrote:
> What objects is this change for?

There are a couple of objects extended by only a few functions. By not
converting the object to slow mode before and back to fast after adding those
functions, we unnecessarily create a transition chain. For examples see
object-observe.js (last dozen of lines).

Powered by Google App Engine
This is Rietveld 408576698